Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue fix 4874 and 4752 #5319

Merged
merged 3 commits into from
Sep 14, 2022
Merged

Conversation

Lyndon-Li
Copy link
Contributor

@Lyndon-Li Lyndon-Li commented Sep 9, 2022

Fix issue 4874 and 4752: check the daemonset pod is running in the node where the workload pod resides before running the PVB for the pod

Fixes #4874
Fixes #4752

@codecov-commenter
Copy link

Codecov Report

Merging #5319 (d6c995a) into main (325b8c0) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #5319      +/-   ##
==========================================
- Coverage   40.86%   40.84%   -0.02%     
==========================================
  Files         233      233              
  Lines       20225    20241      +16     
==========================================
+ Hits         8264     8267       +3     
- Misses      11361    11375      +14     
+ Partials      600      599       -1     
Impacted Files Coverage Δ
pkg/cmd/server/server.go 6.61% <0.00%> (-0.02%) ⬇️
pkg/podvolume/backupper.go 4.66% <0.00%> (-0.15%) ⬇️
pkg/podvolume/backupper_factory.go 0.00% <0.00%> (ø)
pkg/podvolume/util.go 78.32% <0.00%> (-4.65%) ⬇️
pkg/uploader/provider/kopia.go 52.84% <0.00%> (-4.07%) ⬇️
pkg/restore/restore.go 64.83% <0.00%> (+0.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

pkg/nodeagent/node_agent.go Show resolved Hide resolved
pkg/podvolume/util.go Outdated Show resolved Hide resolved
Signed-off-by: Lyndon-Li <[email protected]>
@Lyndon-Li Lyndon-Li merged commit 100d6b4 into vmware-tanzu:main Sep 14, 2022
@Lyndon-Li Lyndon-Li deleted the issue-fix-4874 branch September 14, 2022 03:05
@danfengliu
Copy link
Contributor

From aspect of user experience, this pull request will do some help on issue #2967/#4952 instead of 4 hours timeout.

@jerry-jibu
Copy link

@Lyndon-Li thanks for the fix. Besides backup, I think it should be similar for restore error handling when restic pod can't be scheduled or running on the node.

@Lyndon-Li
Copy link
Contributor Author

@jerry-jibu There is a separate issue for restore #5043, another PR will be submitted to fix it with a slightly different approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants