Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin versioning v1 refactor for VolumeSnapshotter #5318

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

sseago
Copy link
Collaborator

@sseago sseago commented Sep 8, 2022

Thank you for contributing to Velero!

Please add a summary of your change

plugin versioning v1 refactor for VolumeSnapshotter
(depends on #5312)

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • [x ] Accepted the DCO. Commits without the DCO will delay acceptance.
  • [ x] Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@sseago sseago force-pushed the volumesnapshotter-refactor branch 2 times, most recently from 8d35dbd to 7c08ebf Compare September 8, 2022 23:31
@codecov-commenter
Copy link

Codecov Report

Merging #5318 (7c08ebf) into main (94a9a7c) will decrease coverage by 0.09%.
The diff coverage is 35.09%.

@@            Coverage Diff             @@
##             main    #5318      +/-   ##
==========================================
- Coverage   40.69%   40.59%   -0.10%     
==========================================
  Files         233      233              
  Lines       20097    20264     +167     
==========================================
+ Hits         8179     8227      +48     
- Misses      11321    11437     +116     
- Partials      597      600       +3     
Impacted Files Coverage Δ
internal/velero/serverstatusrequest.go 0.00% <0.00%> (ø)
pkg/cmd/server/server.go 6.62% <0.00%> (-0.04%) ⬇️
pkg/controller/backup_deletion_controller.go 57.52% <0.00%> (-1.10%) ⬇️
pkg/controller/server_status_request_controller.go 66.15% <ø> (ø)
pkg/plugin/clientmgmt/process/logrus_adapter.go 17.56% <ø> (ø)
...g/plugin/clientmgmt/process/restartable_process.go 0.00% <0.00%> (ø)
pkg/plugin/framework/action_resolver.go 6.89% <0.00%> (ø)
pkg/plugin/framework/backup_item_action.go 0.00% <0.00%> (ø)
pkg/plugin/framework/backup_item_action_client.go 0.00% <0.00%> (ø)
pkg/plugin/framework/common/client_errors.go 0.00% <0.00%> (ø)
... and 85 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sseago sseago force-pushed the volumesnapshotter-refactor branch from c258523 to b608835 Compare September 21, 2022 17:47
@blackpiglet blackpiglet merged commit b7f5cbd into vmware-tanzu:main Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants