A little note about TTL expiration #5315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think is necessary this little comment about TTL expiration, because it can be confusing when the expiration time has passed and the data allocated and the snapshots are not erased at that time. Signed-off-by: Aaron Arias <[email protected]>
|
/kind changelog-not-required |
github-actions
bot
added
the
kind/changelog-not-required
qiuming-best
approved these changes
Sep 14, 2022
qiuming-best
requested review from
Lyndon-Li
and removed request for
a-mccarthy
Lyndon-Li
approved these changes
Sep 14, 2022
Codecov Report
@@ Coverage Diff @@
## main #5315 +/- ##
=======================================
Coverage 40.62% 40.62%
=======================================
Files 233 233
Lines 20271 20271
=======================================
Hits 8235 8235
Misses 11437 11437
Partials 599 599 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this little comment about TTL expiration is needed, because it can be confusing when the expiration time has passed and the data allocated and the snapshots are not erased at that time.
Signed-off-by: Aaron Arias [email protected]
Thank you for contributing to Velero!
Please add a summary of your change
I think this little comment about TTL expiration is needed, because it can be confusing when the expiration time has passed and the data allocated and the snapshots are not erased at that time.
Does your change fix a particular issue?
No.
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.