Check for empty ns list before checking nslist[0] #5302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiuming-best
force-pushed
the
issue-5236
branch
from
ab16360 to
1661721
Compare
In determining whether a backup includes all namespaces, item_collector checks for an empty string in the first element of the ns list. If processing includes+excludes results in an empty list, treat this as another case of a not-all-namespaces backup rather than crashing velero. Signed-off-by: Scott Seago <[email protected]>
qiuming-best
force-pushed
the
issue-5236
branch
from
1661721 to
9937607
Compare
qiuming-best
requested review from
ywk253100,
Lyndon-Li and
reasonerjt
and removed request for
shubham-pampattiwar
Codecov Report
@@ Coverage Diff @@
## release-1.9 #5302 +/- ##
===============================================
- Coverage 41.37% 41.33% -0.04%
===============================================
Files 211 211
Lines 18462 18465 +3
===============================================
- Hits 7638 7633 -5
- Misses 10251 10258 +7
- Partials 573 574 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
blackpiglet
approved these changes
Sep 7, 2022
Lyndon-Li
approved these changes
Sep 7, 2022
danfengliu
pushed a commit
to danfengliu/velero
that referenced
this pull request
Oct 14, 2022
Check for empty ns list before checking nslist[0]
danfengliu
pushed a commit
to danfengliu/velero
that referenced
this pull request
Oct 15, 2022
Check for empty ns list before checking nslist[0]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In determining whether a backup includes all namespaces, item_collector checks for an empty string in the first element of the ns list. If processing includes+excludes results in an empty list, treat this as another case of a not-all-namespaces backup rather than crashing velero.
Signed-off-by: Scott Seago [email protected]
Thank you for contributing to Velero!
Please add a summary of your change
In determining whether a backup includes all namespaces, item_collector
checks for an empty string in the first element of the ns list. If processing
includes+excludes results in an empty list, treat this as another case
of a not-all-namespaces backup rather than crashing velero.
Does your change fix a particular issue?
Fixes #(issue)
Fixes #5235
Fixes #5266
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.