Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kopia Pod Volume Backup/Restore Smoking Test Changes #5282

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

Lyndon-Li
Copy link
Contributor

Add changes for problems/enhancements found during smoking test for Kopia pod volume backup/restore

@Lyndon-Li Lyndon-Li self-assigned this Sep 5, 2022
@Lyndon-Li Lyndon-Li force-pushed the kopia-pvbr-smoking-test branch from 2f95dc4 to a97fb29 Compare September 5, 2022 04:14
@Lyndon-Li Lyndon-Li force-pushed the kopia-pvbr-smoking-test branch 3 times, most recently from 895c317 to b4364b1 Compare September 5, 2022 05:10
@codecov-commenter
Copy link

Codecov Report

Merging #5282 (b4364b1) into main (0282e65) will decrease coverage by 0.11%.
The diff coverage is 12.24%.

@@            Coverage Diff             @@
##             main    #5282      +/-   ##
==========================================
- Coverage   40.73%   40.61%   -0.12%     
==========================================
  Files         232      233       +1     
  Lines       20228    20277      +49     
==========================================
- Hits         8239     8236       -3     
- Misses      11390    11443      +53     
+ Partials      599      598       -1     
Impacted Files Coverage Δ
pkg/controller/pod_volume_restore_controller.go 25.39% <0.00%> (+0.52%) ⬆️
pkg/podvolume/restorer.go 11.64% <0.00%> (-0.09%) ⬇️
pkg/podvolume/util.go 82.96% <0.00%> (-2.54%) ⬇️
pkg/repository/backup_repo_op.go 0.00% <0.00%> (ø)
pkg/repository/provider/restic.go 0.00% <0.00%> (ø)
pkg/repository/udmrepo/kopialib/lib_repo.go 28.91% <0.00%> (-0.24%) ⬇️
pkg/uploader/kopia/snapshot.go 35.79% <0.00%> (-0.63%) ⬇️
pkg/uploader/provider/provider.go 0.00% <0.00%> (ø)
pkg/util/logging/kopia_log.go 24.32% <0.00%> (ø)
pkg/repository/manager.go 18.89% <7.14%> (-2.16%) ⬇️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Lyndon-Li
Copy link
Contributor Author

Lyndon-Li commented Sep 5, 2022

Fixed issues:

  1. PVB/PVR controller gets BackupRepository and ensure it is ready
  2. ensureRepo function in BackupRepositoryController checks the error message "Is there a repository at the following location?", this is for Restic only, we need to support Kopia path
  3. We have a logic in BackupStorageLocationController that checks the folder in the remote object store. For Kopia path, we've added a new folder for Kopia repository, we need to enhance the check logic, otherwise, it reports errors
  4. Add support to write Kopia log to Velero log for Kopia uploader
  5. The "logSource" field in kopia_log is duplicated with the existing Velero log, so changed it to "logModule"
  6. Fixed the problem that Restorer missed filling the UploaderType when creating BackupRepository
  7. Fixed a problem that rp.extraFlags may be overwritten when there are parallel backups
  8. Change the concurrent number of upstream write to the default value of Kopia
  9. Remove wrapping errors for io.Reader, io.Writer, io.Closer and io.Seeker in kopia_lib, as the caller may track the well known system errors

@Lyndon-Li Lyndon-Li force-pushed the kopia-pvbr-smoking-test branch 2 times, most recently from 7816cc3 to 30022f6 Compare September 5, 2022 10:54
@Lyndon-Li Lyndon-Li force-pushed the kopia-pvbr-smoking-test branch from 30022f6 to a90ba3d Compare September 7, 2022 05:23
Copy link
Contributor

@reasonerjt reasonerjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Lyndon-Li Lyndon-Li merged commit 8888f87 into vmware-tanzu:main Sep 7, 2022
@Lyndon-Li Lyndon-Li deleted the kopia-pvbr-smoking-test branch September 7, 2022 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants