check vsc null pointer

[lilongfeng0902]

Thank you for contributing to Velero!

Please add a summary of your change

Fix a little problem, add a null pointer to judge.

Does your change fix a particular issue?

none
Fixes #(issue)
none

Please indicate you've done the following:

• Accepted the DCO. Commits without the DCO will delay acceptance.
• Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
• Updated the corresponding documentation in site/content/docs/main.

Signed-off-by: 李龙峰 [email protected]

[sseago]

The changelog filename doesn't match the PR, since a new PR was created. You need to rename "changelogs/unreleased/5213-lilongfeng0902" to "changelogs/unreleased/5217-lilongfeng0902" in this PR.

[lilongfeng0902]

The changelog filename doesn't match the PR, since a new PR was created. You need to rename "changelogs/unreleased/5213-lilongfeng0902" to "changelogs/unreleased/5217-lilongfeng0902" in this PR.

Thanks for your review, I have did it.
Signed-off-by: 李龙峰 [email protected]

[codecov-commenter]

Codecov Report

Merging #5217 (66b8ed8) into main (5b6d361) will increase coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #5217      +/-   ##
==========================================
+ Coverage   41.60%   41.67%   +0.07%     
==========================================
  Files         215      216       +1     
  Lines       18643    18794     +151     
==========================================
+ Hits         7756     7833      +77     
- Misses      10309    10377      +68     
- Partials      578      584       +6     

Impacted Files	Coverage Δ
pkg/controller/backup_controller.go	48.26% <0.00%> (-0.22%)	⬇️
pkg/restore/restore.go	64.06% <0.00%> (-0.57%)	⬇️
pkg/install/resources.go	52.31% <0.00%> (-0.25%)	⬇️
pkg/cmd/server/server.go	6.43% <0.00%> (-0.05%)	⬇️
pkg/uploader/types.go	100.00% <0.00%> (ø)
pkg/install/deployment.go	87.27% <0.00%> (+0.35%)	⬆️
pkg/repository/provider/unified_repo.go	54.20% <0.00%> (+1.32%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[blackpiglet]

Thanks for the effort.
Please squash the commit into one, and force push to make the commit list simple and clean.

[lilongfeng0902]

Thanks for the effort. Please squash the commit into one, and force push to make the commit list simple and clean.

I squash the commit into one, and force push the commit. Thanks.

[blackpiglet]

Sorry, I didn't notice this in last review. It should be something like this.

				if nil == vsc {
					logger.Errorf("Not find %s from the vscMap", vs.Status.BoundVolumeSnapshotContentName)
					return
				}
				if vsc.Spec.DeletionPolicy == snapshotv1api.VolumeSnapshotContentDelete {
					modifyVSCFlag = true
				}

[lilongfeng0902]

Sorry, I didn't notice this in last review. It should be something like this.

				if nil == vsc {
					logger.Errorf("Not find %s from the vscMap", vs.Status.BoundVolumeSnapshotContentName)
					return
				}
				if vsc.Spec.DeletionPolicy == snapshotv1api.VolumeSnapshotContentDelete {
					modifyVSCFlag = true
				}

Yes，that's look like good, I have did that. Please check again. Thank you.

[reasonerjt]

Should it be nil== vsc?

[lilongfeng0902]

Yes, you're right. Too careless……

Ignore problematic nil checking.