Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GC controller with kubebuilder #5215

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

allenxu404
Copy link
Contributor

@allenxu404 allenxu404 commented Aug 16, 2022

Thank you for contributing to Velero!

Please add a summary of your change

  • Refactor gc controller with kubebuilder

Does your change fix a particular issue?

Fixes #5023

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2022

Codecov Report

Merging #5215 (aa5f389) into main (a71237c) will decrease coverage by 0.46%.
The diff coverage is 40.62%.

@@            Coverage Diff             @@
##             main    #5215      +/-   ##
==========================================
- Coverage   41.60%   41.13%   -0.47%     
==========================================
  Files         215      218       +3     
  Lines       18643    18882     +239     
==========================================
+ Hits         7756     7768      +12     
- Misses      10309    10535     +226     
- Partials      578      579       +1     
Impacted Files Coverage Δ
pkg/cmd/server/server.go 6.63% <0.00%> (+0.15%) ⬆️
pkg/controller/gc_controller.go 56.31% <46.42%> (-20.01%) ⬇️
pkg/controller/generic_controller.go 8.79% <0.00%> (-63.74%) ⬇️
pkg/install/resources.go 52.31% <0.00%> (-0.25%) ⬇️
pkg/controller/backup_deletion_controller.go 56.74% <0.00%> (ø)
pkg/controller/restic_repository_controller.go 54.36% <0.00%> (ø)
pkg/restic/repository_manager.go
pkg/restic/repository_keys.go
pkg/repository/manager.go 20.40% <0.00%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@allenxu404 allenxu404 marked this pull request as ready for review August 16, 2022 03:38
@github-actions github-actions bot requested a review from dsu-igeek August 16, 2022 03:39
@allenxu404 allenxu404 force-pushed the issue5023 branch 2 times, most recently from b47581d to aa5f389 Compare August 18, 2022 11:23
@blackpiglet blackpiglet merged commit e849441 into vmware-tanzu:main Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor GC controller with kubebuilder
4 participants