Clean backups after each test and fix exclude label test issue #5210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danfengliu
force-pushed
the
clean-backups-after-each-test
branch
12 times, most recently
from
6744114 to
5c14586
Compare
danfengliu
added
the
kind/changelog-not-required
danfengliu
force-pushed
the
clean-backups-after-each-test
branch
from
5c14586 to
5878589
Compare
danfengliu
changed the title
danfengliu
force-pushed
the
clean-backups-after-each-test
branch
2 times, most recently
from
ac57ec2 to
cb3f32e
Compare
Codecov Report
@@ Coverage Diff @@
## main #5210 +/- ##
=======================================
Coverage 41.72% 41.72%
=======================================
Files 216 216
Lines 18791 18791
=======================================
Hits 7841 7841
Misses 10367 10367
Partials 583 583 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
danfengliu
force-pushed
the
clean-backups-after-each-test
branch
2 times, most recently
from
413d9ab to
c2d14ff
Compare
blackpiglet
previously approved these changes
Aug 18, 2022
sseago
requested changes
Aug 18, 2022
danfengliu
force-pushed
the
clean-backups-after-each-test
branch
from
c2d14ff to
66227db
Compare
1. Clean backups after each test to avoid exceeding limitation of storage capability during E2E test; 2. Fix exlude label test issue that namespace should not be included and excluded at the same time no matter by which way to config. Signed-off-by: danfengl <[email protected]>
danfengliu
force-pushed
the
clean-backups-after-each-test
branch
from
66227db to
6e80612
Compare
blackpiglet
approved these changes
Aug 19, 2022
qiuming-best
approved these changes
Aug 19, 2022
sseago
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #5194 #5229
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.