Kopia Integration: Unified Repository Provider - Implementation #5179
Conversation
Lyndon-Li
force-pushed
the
udmrepo-dev-02
branch
from
8df9297 to
97b75d0
Compare
Codecov Report
@@ Coverage Diff @@
## main #5179 +/- ##
==========================================
+ Coverage 41.32% 41.50% +0.18%
==========================================
Files 214 214
Lines 18710 18816 +106
==========================================
+ Hits 7731 7809 +78
- Misses 10405 10431 +26
- Partials 574 576 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Lyndon-Li
force-pushed
the
udmrepo-dev-02
branch
4 times, most recently
from
e97f403 to
1045661
Compare
Lyndon-Li
force-pushed
the
udmrepo-dev-02
branch
3 times, most recently
from
5871bba to
53fc3ad
Compare
Signed-off-by: Lyndon-Li <[email protected]>
Lyndon-Li
force-pushed
the
udmrepo-dev-02
branch
from
53fc3ad to
649c3a7
Compare
|
|
||
| func GetRepoUser() (username, domain string) { | ||
| return defaultUsername, defaultDomain | ||
| } |
There was a problem hiding this comment.
In one of my functions that needs to get Repo User info, so I must need to import service package, but nothing to do with udmrepo service, should it be one configuration for udmrepo rather than configuration in service?
There was a problem hiding this comment.
As the discussion, the service package means the package to provide all the methods exposed by the unified repo. In this way, it is rational to put the GetRepoUser in the service package.
However, the package name may be misleading that the package binds to the BackupRepoService interface. Therefore:
- Let's add some comments to clarify the usage of the package
- When we see a better name in future, we will change the package name
Add changes for Kopia Integration: Unified Repository Provider - method implementation
Related Issue: ##5079