Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restic backups to multiple backup storage locations bug #5172

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

qiuming-best
Copy link
Contributor

Signed-off-by: Ming [email protected]

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

For multiple backup locations to do the backup, it will wrongly find the parent podvolumebackups.
Fixes #(issue)
#5164

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2022

Codecov Report

Merging #5172 (828e28a) into main (52fd18e) will increase coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #5172      +/-   ##
==========================================
+ Coverage   41.20%   41.25%   +0.04%     
==========================================
  Files         212      212              
  Lines       18666    18663       -3     
==========================================
+ Hits         7692     7700       +8     
+ Misses      10399    10389      -10     
+ Partials      575      574       -1     
Impacted Files Coverage Δ
pkg/controller/pod_volume_backup_controller.go 43.67% <0.00%> (ø)
pkg/plugin/framework/server.go 0.00% <0.00%> (ø)
pkg/restore/restore.go 64.63% <0.00%> (+0.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@blackpiglet
Copy link
Contributor

Since there could be multiple mostRecentPVB during traverse the PVB list, if there are multiple BSLs, there should a set to keep multiple values of mostRecentPVB.

@qiuming-best
Copy link
Contributor Author

Since there could be multiple mostRecentPVB during traverse the PVB list, if there are multiple BSLs, there should a set to keep multiple values of mostRecentPVB.

@blackpiglet indeed there may have lots of PVB for one PVC, but the getParentSnapshot should returns the newest PVB for one specific BSL.

@qiuming-best qiuming-best merged commit 701256d into vmware-tanzu:main Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants