Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kopia Integration Change - Storage Configuration #5142

Merged
merged 2 commits into from
Jul 29, 2022

Conversation

Lyndon-Li
Copy link
Contributor

Kopia Integration: Add the Unified Repository Interface definition.
Kopia Integration: Add the changes for Unified Repository storage config.

Related Issues; #5076, #5080

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2022

Codecov Report

Merging #5142 (60ef1d6) into main (67d98fe) will decrease coverage by 0.08%.
The diff coverage is 35.11%.

@@            Coverage Diff             @@
##             main    #5142      +/-   ##
==========================================
- Coverage   41.32%   41.23%   -0.09%     
==========================================
  Files         211      212       +1     
  Lines       18445    18667     +222     
==========================================
+ Hits         7622     7698      +76     
- Misses      10250    10395     +145     
- Partials      573      574       +1     
Impacted Files Coverage Δ
pkg/restic/common.go 65.85% <0.00%> (ø)
pkg/repository/repoconfig/azure.go 5.98% <7.14%> (ø)
pkg/repository/repoconfig/aws.go 24.39% <24.39%> (ø)
pkg/repository/repoconfig/gcp.go 53.84% <25.00%> (ø)
pkg/repository/repoprovider/unified_repo.go 40.86% <40.86%> (ø)
pkg/repository/repoconfig/config.go 95.91% <50.00%> (ø)
pkg/controller/restic_repository_controller.go 54.36% <100.00%> (ø)
pkg/restic/backupper.go 5.00% <0.00%> (-0.03%) ⬇️
pkg/restic/repository_ensurer.go 0.00% <0.00%> (ø)
pkg/controller/restore_controller.go 66.51% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67d98fe...60ef1d6. Read the comment docs.

@Lyndon-Li Lyndon-Li force-pushed the udmrepo-dev branch 3 times, most recently from 65c30e9 to 60ef1d6 Compare July 22, 2022 03:10
@ywk253100
Copy link
Contributor

A general comment about the naming of package and object:
e.g. The interface RepositoryProvider defined in pkg/repository/repoprovider/repo_provider.go
Usually, we define it as an interface called Provider in pkg/repository/provider/provider.go

And similar for the package:
pkg/repository/repoconfig/aws.go -> pkg/repository/config/aws.go

@Lyndon-Li
Copy link
Contributor Author

A general comment about the naming of package and object: e.g. The interface RepositoryProvider defined in pkg/repository/repoprovider/repo_provider.go Usually, we define it as an interface called Provider in pkg/repository/provider/provider.go

And similar for the package: pkg/repository/repoconfig/aws.go -> pkg/repository/config/aws.go

@ywk253100 The package folder name and file name has been changed. Thanks.

ywk253100
ywk253100 previously approved these changes Jul 29, 2022
Signed-off-by: Lyndon-Li <[email protected]>
@ywk253100 ywk253100 merged commit 52fd18e into vmware-tanzu:main Jul 29, 2022
@Lyndon-Li Lyndon-Li deleted the udmrepo-dev branch July 29, 2022 08:08
@Lyndon-Li Lyndon-Li added this to the 1.10 milestone Aug 1, 2022
danfengliu pushed a commit to danfengliu/velero that referenced this pull request Sep 13, 2022
* unified repo storge config

Signed-off-by: Lyndon-Li <[email protected]>

* add UT

Signed-off-by: Lyndon-Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants