Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the CRD for kopia integration #5135

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

reasonerjt
Copy link
Contributor

This commit adds additional fields to podvolumebackup and podvolumerestore. The resticrepository will be renamed to
backuprepository

Signed-off-by: Daniel Jiang [email protected]

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@github-actions github-actions bot requested review from dsu-igeek and Lyndon-Li July 20, 2022 09:02
@reasonerjt reasonerjt force-pushed the update-crd-for-kopia branch from 1bc434c to a422c9c Compare July 20, 2022 10:35
@reasonerjt reasonerjt force-pushed the update-crd-for-kopia branch 2 times, most recently from 8cbb3bc to bd1066a Compare July 20, 2022 14:04
@codecov-commenter
Copy link

Codecov Report

Merging #5135 (bd1066a) into main (5693993) will decrease coverage by 0.01%.
The diff coverage is 30.00%.

@@            Coverage Diff             @@
##             main    #5135      +/-   ##
==========================================
- Coverage   41.33%   41.31%   -0.02%     
==========================================
  Files         211      211              
  Lines       18443    18447       +4     
==========================================
- Hits         7624     7622       -2     
- Misses      10247    10252       +5     
- Partials      572      573       +1     
Impacted Files Coverage Δ
pkg/cmd/cli/backuplocation/delete.go 0.00% <0.00%> (ø)
pkg/cmd/server/server.go 6.50% <0.00%> (ø)
pkg/cmd/util/output/output.go 0.00% <0.00%> (ø)
pkg/cmd/util/output/restic_repo_printer.go 0.00% <0.00%> (ø)
pkg/controller/restore_controller.go 66.51% <ø> (ø)
pkg/restic/backupper.go 5.00% <0.00%> (-0.03%) ⬇️
pkg/restic/repository_ensurer.go 0.00% <0.00%> (ø)
pkg/restic/repository_manager.go 8.12% <0.00%> (ø)
pkg/restic/restorer.go 0.00% <0.00%> (ø)
pkg/controller/restic_repository_controller.go 54.36% <72.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5693993...bd1066a. Read the comment docs.

@sseago
Copy link
Collaborator

sseago commented Jul 20, 2022

We'll need to be careful with the resticrepository->backuprepository change on upgrade. Do we need to delete the old CRD on upgrade? Any problems with existing installs being upgraded in terms of what was in the prior resticrepository metadata, or will everything just get recreated from scratch as necessary?

@reasonerjt
Copy link
Contributor Author

@sseago
Copy link
Collaborator

sseago commented Jul 20, 2022

@reasonerjt Ahh thanks. I remember reading that now when I went over this the first time, but I'd forgotten. So it's covered.

@reasonerjt reasonerjt force-pushed the update-crd-for-kopia branch 2 times, most recently from 27c56d3 to c39d0a9 Compare July 21, 2022 15:24
@reasonerjt reasonerjt closed this Jul 21, 2022
@reasonerjt reasonerjt reopened this Jul 21, 2022
@github-actions github-actions bot requested review from sseago and ywk253100 July 21, 2022 15:59
This commit adds additional fields to podvolumebackup
and podvolumerestore.  The resticrepository will be renamed to
backuprepository

Signed-off-by: Daniel Jiang <[email protected]>
@reasonerjt reasonerjt force-pushed the update-crd-for-kopia branch from c39d0a9 to f562a7c Compare July 21, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants