Modify BackupStoreGetter to avoid BSL spec changes #5134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass in a new copy of the map of config values rather than modifying the BSL Spec.Config and then pass in that field. Signed-off-by: Scott Seago <[email protected]>
sseago
force-pushed
the
backupstoregettermap
branch
from
bd31f23 to
b5c14d9
Compare
Codecov Report
@@ Coverage Diff @@
## release-1.9 #5134 +/- ##
===============================================
- Coverage 41.34% 41.33% -0.02%
===============================================
Files 211 211
Lines 18438 18440 +2
===============================================
- Hits 7624 7622 -2
- Misses 10242 10245 +3
- Partials 572 573 +1
Continue to review full report at Codecov.
|
shubham-pampattiwar
approved these changes
Jul 19, 2022
kaovilai
approved these changes
Jul 19, 2022
blackpiglet
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry-picked from #5122 to release-1.9)
Pass in a new copy of the map of config values rather than
modifying the BSL Spec.Config and then pass in that field.
Signed-off-by: Scott Seago [email protected]
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.