Let "make shell xxx" respect GOPROXY #5128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit mitigates the issue for running "make update" locally when the network is not friendly for accessing the default "proxy.golang.org" Signed-off-by: Daniel Jiang <[email protected]>
reasonerjt
force-pushed
the
make-shell-goproxy
branch
from
1089adc to
9173ac1
Compare
ywk253100
approved these changes
Jul 19, 2022
qiuming-best
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit mitigates the issue for running "make update" locally when
the network is not friendly for accessing the default "proxy.golang.org"
Signed-off-by: Daniel Jiang [email protected]
Thank you for contributing to Velero!
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.