Add migration E2E test #5124
Merged
Add migration E2E test #5124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danfengliu
added
kind/changelog-not-required
github-actions
bot
added
Dependencies
danfengliu
force-pushed
the
add-migration-e2e-test
branch
13 times, most recently
from
9e2dcbe to
6be34fa
Compare
github-actions
bot
removed
the
Dependencies
danfengliu
force-pushed
the
add-migration-e2e-test
branch
2 times, most recently
from
cba508e to
f25bb8c
Compare
github-actions
bot
added
the
Dependencies
danfengliu
force-pushed
the
add-migration-e2e-test
branch
2 times, most recently
from
b635a59 to
f670c06
Compare
github-actions
bot
removed
the
Dependencies
danfengliu
force-pushed
the
add-migration-e2e-test
branch
from
f670c06 to
245b72e
Compare
danfengliu
force-pushed
the
add-migration-e2e-test
branch
14 times, most recently
from
41de9d5 to
1f26b73
Compare
|
|
qiuming-best
reviewed
Aug 9, 2022
test/e2e/types.go
Outdated
| StandbyCluster string | ||
| ClientToBeInstall TestClient | ||
| DefaultClient TestClient | ||
| StandbyClient TestClient |
There was a problem hiding this comment.
Maybe it is better to use pointer type (*TestClient)
There was a problem hiding this comment.
Right, good point!
It's not needed, I will remove it. |
danfengliu
force-pushed
the
add-migration-e2e-test
branch
4 times, most recently
from
8b19141 to
1f2c48b
Compare
danfengliu
force-pushed
the
add-migration-e2e-test
branch
from
1f2c48b to
b8b1961
Compare
Signed-off-by: danfengl <[email protected]>
danfengliu
force-pushed
the
add-migration-e2e-test
branch
from
b8b1961 to
fb445b3
Compare
qiuming-best
approved these changes
Aug 9, 2022
blackpiglet
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: danfengl [email protected]
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #4791
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.