Dump stack trace when the plugin server handles panic #5110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mitigate the issue mentioned in vmware-tanzu#4782 When there's a bug or misconfiguration that causes nil pointer there will be more stack trace information to help us debug. Signed-off-by: Daniel Jiang <[email protected]>
reasonerjt
force-pushed
the
plugin-panic-trace
branch
from
9be79a6 to
9102f53
Compare
Codecov Report
@@ Coverage Diff @@
## main #5110 +/- ##
==========================================
- Coverage 41.30% 41.29% -0.01%
==========================================
Files 210 211 +1
Lines 18439 18443 +4
==========================================
Hits 7616 7616
- Misses 10253 10254 +1
- Partials 570 573 +3
Continue to review full report at Codecov.
|
shubham-pampattiwar
approved these changes
Jul 11, 2022
blackpiglet
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitigate the issue mentioned in #4782
When there's a bug or misconfiguration that causes nil pointer there
will be more stack trace information to help us debug.
Signed-off-by: Daniel Jiang [email protected]
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #4815
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.