Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix plugins incompatible issue in upgrade test #4141

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Fix plugins incompatible issue in upgrade test #4141

merged 1 commit into from
Sep 22, 2021

Conversation

danfengliu
Copy link
Contributor

Signed-off-by: danfengl [email protected]

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

@github-actions github-actions bot requested review from sseago and zubron September 14, 2021 13:42
ywk253100
ywk253100 reviewed Sep 14, 2021
View reviewed changes
test/e2e/velero_utils.go Outdated Show resolved Hide resolved
@danfengliu danfengliu force-pushed the fix-plugins-incompatible-in-upgrade-test-issue branch 2 times, most recently from 7a3fd2a to 185f23e Compare September 14, 2021 14:26
dsu-igeek
dsu-igeek suggested changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@dsu-igeek dsu-igeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a spelling change

test/e2e/velero_utils.go Outdated Show resolved Hide resolved
zubron
zubron reviewed Sep 15, 2021
View reviewed changes
test/e2e/velero_utils.go Outdated Show resolved Hide resolved
ywk253100
ywk253100 reviewed Sep 15, 2021
View reviewed changes
test/e2e/install.go Outdated Show resolved Hide resolved
ywk253100
ywk253100 reviewed Sep 15, 2021
View reviewed changes
test/e2e/velero_utils.go Outdated Show resolved Hide resolved
ywk253100
ywk253100 reviewed Sep 15, 2021
View reviewed changes
test/e2e/install.go Outdated Show resolved Hide resolved
@danfengliu danfengliu force-pushed the fix-plugins-incompatible-in-upgrade-test-issue branch 2 times, most recently from b500e3e to f1e0339 Compare September 16, 2021 01:21
ywk253100
ywk253100 reviewed Sep 16, 2021
View reviewed changes
test/e2e/velero_utils.go Outdated Show resolved Hide resolved
ywk253100
ywk253100 reviewed Sep 16, 2021
View reviewed changes
test/e2e/velero_utils.go Outdated Show resolved Hide resolved
ywk253100
ywk253100 reviewed Sep 16, 2021
View reviewed changes
test/e2e/velero_utils.go Outdated Show resolved Hide resolved
@danfengliu danfengliu force-pushed the fix-plugins-incompatible-in-upgrade-test-issue branch from f1e0339 to 8aec0d0 Compare September 16, 2021 09:51
ywk253100
ywk253100 reviewed Sep 16, 2021
View reviewed changes
test/e2e/velero_utils.go Outdated Show resolved Hide resolved
ywk253100
ywk253100 reviewed Sep 16, 2021
View reviewed changes
test/e2e/install.go Outdated Show resolved Hide resolved
ywk253100
ywk253100 reviewed Sep 16, 2021
View reviewed changes
test/e2e/upgrade_test.go Outdated Show resolved Hide resolved
@danfengliu danfengliu force-pushed the fix-plugins-incompatible-in-upgrade-test-issue branch 4 times, most recently from 4e280a1 to 3d540a0 Compare September 17, 2021 08:55
@danfengliu danfengliu force-pushed the fix-plugins-incompatible-in-upgrade-test-issue branch 2 times, most recently from b47eccd to ff39e07 Compare September 17, 2021 09:12
ywk253100
ywk253100 previously approved these changes Sep 17, 2021
View reviewed changes
@danfengliu danfengliu force-pushed the fix-plugins-incompatible-in-upgrade-test-issue branch 2 times, most recently from be995c1 to b6b9268 Compare September 17, 2021 14:18
@ywk253100 ywk253100 added this to the v1.7.0 milestone Sep 21, 2021
@danfengliu
Fix plugins incompatible issue in upgrade test
b4cf8c8 
In upgrade test, both original and to-be-upgrading velero installation should use the compatible plugins, but currently, plugin value is determined by provider.

Signed-off-by: danfengl <[email protected]>
@danfengliu danfengliu force-pushed the fix-plugins-incompatible-in-upgrade-test-issue branch from b6b9268 to b4cf8c8 Compare September 22, 2021 02:11
dsu-igeek
dsu-igeek approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@dsu-igeek dsu-igeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@dsu-igeek dsu-igeek merged commit 8827b4f into vmware-tanzu:main Sep 22, 2021
danfengliu added a commit to danfengliu/velero that referenced this pull request Jan 25, 2022
@danfengliu
Fix plugins incompatible issue in upgrade test (vmware-tanzu#4141)
ebb5465 
In upgrade test, both original and to-be-upgrading velero installation should use the compatible plugins, but currently, plugin value is determined by provider.

Signed-off-by: danfengl <[email protected]>
gyaozhou pushed a commit to gyaozhou/velero-read that referenced this pull request May 14, 2022
@danfengliu @gyaozhou
Fix plugins incompatible issue in upgrade test (vmware-tanzu#4141)
6610ff8 
In upgrade test, both original and to-be-upgrading velero installation should use the compatible plugins, but currently, plugin value is determined by provider.

Signed-off-by: danfengl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zubron zubron zubron left review comments

@ywk253100 ywk253100 ywk253100 approved these changes

@dsu-igeek dsu-igeek dsu-igeek approved these changes

@sseago sseago Awaiting requested review from sseago

Assignees

@danfengliu danfengliu

Labels
has-changelog has-e2e-tests
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@danfengliu @dsu-igeek @zubron @ywk253100