Restic Backup: Add check if Pod is successful or failed for emptyDir.… #3993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix #3812 Signed-off-by: mahaupt <[email protected]>
sseago
requested changes
Jul 27, 2021
Signed-off-by: mahaupt <[email protected]>
|
I just added the missing changelog file |
sseago
approved these changes
Jul 28, 2021
jenting
approved these changes
Aug 4, 2021
gyaozhou
pushed a commit
to gyaozhou/velero-read
that referenced
this pull request
May 14, 2022
vmware-tanzu#3993) * Restic Backup: Add check if Pod is successful or failed for emptyDir. Fix vmware-tanzu#3812 * Add changelog Signed-off-by: mahaupt <[email protected]>
|
my pods are running for openshift all namespace still its give issue for only pod's which has emptyDir its not failing but its stuck like never ending backup |
|
Check if the velero pod has enough resources and is not running out of memory |
|
yes restic memory limit is 2gi and request 500mi while installing i am passing --velero-pod-cpu-limit 1500m --velero-pod-cpu-request 700m --velero-pod-mem-limit 2Gi --velero-pod-mem-request 500Mi --restic-pod-cpu-limit 1500m --restic-pod-cpu-request 500m --restic-pod-mem-limit 2Gi --restic-pod-mem-request 500Mi --default-volumes-to-restic see full logs #5113 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I added a check to exclude restic backups for emptyDirs on stopped but unremoved pods (successful / failed).
Emptydirs are only guaranteed to persist on running / crashing pods.
https://kubernetes.io/docs/concepts/storage/volumes/#emptydir
https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#pod-phase
Please let me know if I shall add a changelog / documentation for this small bugfix.
Does your change fix a particular issue?
Fixes #3812
Please indicate you've done the following:
/kind changelog-not-required.site/content/docs/main.