Fixing multipleNamespaceTest bug - Missing expect statement in test #3983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jai Subash Devmane <[email protected]>
jaidevmane
changed the title
Signed-off-by: Jai Subash Devmane <[email protected]>
|
#3987 seems to be a duplicate of this fix -- the only difference is the failure message. Both PRs are failing CI tests on kind with this change in the same way, although talking to @jaidevmane just now, the tests are succeeding locally. |
3 tasks
|
@jaidevmane The case random failure is a known issue #3970 and I'll raise PR to fix it. |
…ipleNamespaceTestbugfix
|
@ywk253100 Thank you for your guidance. I have incorporated your suggestions as mentioned. |
|
All checks passed. Ready to review. |
ywk253100
approved these changes
Jul 27, 2021
jenting
approved these changes
Jul 27, 2021
dsu-igeek
pushed a commit
to dsu-igeek/velero
that referenced
this pull request
Jul 29, 2021
…mware-tanzu#3983) * Fixing multipleNamespaceTest bug - No expect statement in test * adding changelog Signed-off-by: Jai Subash Devmane <[email protected]> Signed-off-by: Dave Smith-Uchida <[email protected]>
gyaozhou
pushed a commit
to gyaozhou/velero-read
that referenced
this pull request
May 14, 2022
…mware-tanzu#3983) * Fixing multipleNamespaceTest bug - No expect statement in test * adding changelog Signed-off-by: Jai Subash Devmane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jai Subash Devmane [email protected]
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-required.site/content/docs/main.