Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -install-velero flag for e2e tests #3919

Merged
merged 1 commit into from
Jul 20, 2021

Conversation

jaidevmane
Copy link
Contributor

@jaidevmane jaidevmane commented Jul 2, 2021

Thank you for contributing to Velero!

Please add a summary of your change

1.adding install flag to test makefile
2.fixing bug where velero was being uninstalled in the APIGroup test even though the -install-velero flag was set to false

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

@github-actions github-actions bot requested review from jenting and zubron July 2, 2021 20:40
@jaidevmane jaidevmane changed the title 1. adding install flag to test makefile 2.fixing bug where velero was… e2e test suite bug fixes Jul 2, 2021
@jaidevmane jaidevmane changed the title e2e test suite bug fixes Fix -install-velero flag for e2e tests Jul 2, 2021
@jaidevmane jaidevmane changed the title Fix -install-velero flag for e2e tests e2e test suite bug fixes Jul 2, 2021
Signed-off-by: Jai Subash Devmane <[email protected]>
@jaidevmane jaidevmane changed the title e2e test suite bug fixes Fix -install-velero flag for e2e tests Jul 2, 2021
@dymurray
Copy link
Contributor

dymurray commented Jul 2, 2021

LGTM. Please note this PR will be void if #3888 is merged as is.

It's likely untenable for each test to have to maintain the installVelero var, and Carilsia's PR will force that pattern to be rethought.

I will bring this up on the community call next week and figure out what the plan is to move forward.

Copy link
Contributor

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ywk253100 ywk253100 merged commit 7052680 into vmware-tanzu:main Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants