-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Abbie to PR review requests #3666
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some comments, PTAL.
Let me try this change on my repo. I expect that the https://github.com/vmware-tanzu/velero/actions/runs/749498394 |
Yeay, this works! There was a yaml formatting issue that I fixed. I tested this on my repo to confirm that it works as intended. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@zubron PTAL when you have a chance, thank you. |
Signed-off-by: Carlisia <[email protected]>
Signed-off-by: Carlisia <[email protected]>
Signed-off-by: Carlisia <[email protected]>
Signed-off-by: Carlisia <[email protected]>
@ashish-amarnath apparently your review was dismissed when I rebased this with main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The currently used GH action to request PR reviews doesn't have the feature to add reviewers based on file type or path, so added a new one.
Keeping the current one because it does set the author to be the assignee of a PR.
Tested this on a personal repo and it works like so: PRs that contain
.md
files and/or contain files in the/site
path will add Abbie as one of the two reviewers.This system of requesting reviewers based on file/path is not ever going to be entirely perfect. In this case with doc PRs, I can think of a huge, very technical PR that has 1 inconsequential
.md
file requesting Abbie to review it. In this case, Abbie may exclude herself and randomly pick one of the maintainers.@a-mccarthy is very excited about being automatically added as a reviewer for doc PRs!
Signed-off-by: Carlisia [email protected]
Please indicate you've done the following:
/kind changelog-not-required
.site/content/docs/main
.