Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Abbie to PR review requests #3666

Merged
merged 4 commits into from
Apr 20, 2021
Merged

Conversation

carlisia
Copy link
Contributor

@carlisia carlisia commented Apr 6, 2021

The currently used GH action to request PR reviews doesn't have the feature to add reviewers based on file type or path, so added a new one.

Keeping the current one because it does set the author to be the assignee of a PR.

Tested this on a personal repo and it works like so: PRs that contain .md files and/or contain files in the /site path will add Abbie as one of the two reviewers.

This system of requesting reviewers based on file/path is not ever going to be entirely perfect. In this case with doc PRs, I can think of a huge, very technical PR that has 1 inconsequential .md file requesting Abbie to review it. In this case, Abbie may exclude herself and randomly pick one of the maintainers.

@a-mccarthy is very excited about being automatically added as a reviewer for doc PRs!

Signed-off-by: Carlisia [email protected]

Please indicate you've done the following:

@carlisia carlisia added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Apr 6, 2021
Copy link
Member

@ashish-amarnath ashish-amarnath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments, PTAL.

@carlisia
Copy link
Contributor Author

Let me try this change on my repo. I expect that the kentaro-m/[email protected]. action will fail because it won't recognize the content of the yaml file it is reading.

https://github.com/vmware-tanzu/velero/actions/runs/749498394

@carlisia
Copy link
Contributor Author

Yeay, this works! There was a yaml formatting issue that I fixed.

I tested this on my repo to confirm that it works as intended.

Copy link
Member

@ashish-amarnath ashish-amarnath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlisia
Copy link
Contributor Author

@zubron PTAL when you have a chance, thank you.

Carlisia added 4 commits April 19, 2021 14:33
Signed-off-by: Carlisia <[email protected]>
Signed-off-by: Carlisia <[email protected]>
@carlisia
Copy link
Contributor Author

@ashish-amarnath apparently your review was dismissed when I rebased this with main.

@dsu-igeek dsu-igeek self-requested a review April 20, 2021 15:52
Copy link
Contributor

@dsu-igeek dsu-igeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsu-igeek dsu-igeek merged commit 9a000c1 into vmware-tanzu:main Apr 20, 2021
@carlisia carlisia deleted the c-gh-action branch April 20, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants