Revert printer columns #3652
Merged
Revert printer columns #3652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlisia
added
the
kind/release-blocker
|
Thanks @ashish-amarnath and @zubron for helping me git bisect this, and @dsu-igeek for giving troubleshooting directions and also running tests himself! |
ashish-amarnath
previously approved these changes
Mar 31, 2021
zubron
previously approved these changes
Mar 31, 2021
|
It looks like the revert commit also needs to be signed in order to merge. |
added 2 commits
March 31, 2021 14:03
This reverts commit 4178d9d. Signed-off-by: Carlisia <[email protected]>
Signed-off-by: Carlisia <[email protected]>
carlisia
force-pushed
the
c-revert-printer-columns
branch
from
df2a927 to
3fec094
Compare
zubron
approved these changes
Mar 31, 2021
ashish-amarnath
approved these changes
Mar 31, 2021
pradeep288
pushed a commit
to pradeep288/velero
that referenced
this pull request
May 4, 2021
* Revert "Add additional printer columns for CRDs (vmware-tanzu#2881)" This reverts commit 4178d9d. Signed-off-by: Carlisia <[email protected]> * Add generated files Signed-off-by: Carlisia <[email protected]> Signed-off-by: Pradeep Jigalur <[email protected]>
dharmab
pushed a commit
to dharmab/velero
that referenced
this pull request
May 25, 2021
* Revert "Add additional printer columns for CRDs (vmware-tanzu#2881)" This reverts commit 4178d9d. Signed-off-by: Carlisia <[email protected]> * Add generated files Signed-off-by: Carlisia <[email protected]>
ywk253100
pushed a commit
to ywk253100/velero
that referenced
this pull request
Jun 29, 2021
* Revert "Add additional printer columns for CRDs (vmware-tanzu#2881)" This reverts commit 4178d9d. Signed-off-by: Carlisia <[email protected]> * Add generated files Signed-off-by: Carlisia <[email protected]>
gyaozhou
pushed a commit
to gyaozhou/velero-read
that referenced
this pull request
May 14, 2022
* Revert "Add additional printer columns for CRDs (vmware-tanzu#2881)" This reverts commit 4178d9d. Signed-off-by: Carlisia <[email protected]> * Add generated files Signed-off-by: Carlisia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
I think this needs a changelog.
Ok so, weirdly enough, this change fixes the weird CRD install error that only happened on my machine.
I will dig into it a bit more to see what if anything could/can be done differently to address this, "this" being a more specific cause of this problem, whatever it is.
Does your change fix a particular issue?
Fixes #3600
Please indicate you've done the following:
/kind changelog-not-required.site/content/docs/main.