Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore progress reporting bug fix #3583

Merged
merged 3 commits into from
Mar 15, 2021
Merged

Restore progress reporting bug fix #3583

merged 3 commits into from
Mar 15, 2021

Conversation

codegold79
Copy link
Contributor

Summary of change

Fixes the bug introduced by PR #3125.

Does your change fix a particular issue?

Fixes #3571

Please indicate you've done the following:

@codegold79
Copy link
Contributor Author

For reviewers, feel free to skim passed the formatting changes (all in one commit). The important changes are in the commit with the message Update paths to include API group versions.

Screen Shot 2021-03-12 at 4 04 26 PM

@codegold79
Copy link
Contributor Author

/kind changelog-not-required

@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Mar 13, 2021
@codegold79 codegold79 changed the title Restore progress reporting pr bug fix Restore progress reporting bug fix Mar 13, 2021
@carlisia carlisia requested review from carlisia and removed request for ashish-amarnath March 15, 2021 17:50
zubron
zubron reviewed Mar 15, 2021
View reviewed changes
pkg/restore/restore.go Outdated Show resolved Hide resolved
@zubron
Copy link
Contributor

zubron commented Mar 15, 2021

This PR might require a changelog as it's a bug fix. Although, it's for a bug that hasn't been present in a released version of Velero. @carlisia, thoughts on this?

@carlisia
Copy link
Contributor

Although, it's for a bug that hasn't been present in a released version of Velero. @carlisia, thoughts on this?

This is such a good question. I would say no, no need to include it.

I will open an issue to document what deserves a changelog.

zubron
zubron previously approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@zubron zubron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @codegold79!

carlisia
carlisia suggested changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@carlisia carlisia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @codegold79, I'm asking you to revert just a very minor change.

I verified that you have put back in all of your changes from PR #3133, and have not removed anything related to the PR #3125.

This LGTM, thank you for fixing this!

pkg/restore/restore.go Outdated Show resolved Hide resolved
@codegold79 codegold79 requested review from zubron and carlisia March 15, 2021 22:11
@github-actions github-actions bot requested a review from dsu-igeek March 15, 2021 22:25
carlisia
carlisia approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@carlisia carlisia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@carlisia carlisia removed the request for review from dsu-igeek March 15, 2021 22:30
zubron
zubron approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@zubron zubron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @codegold79! 🎉

@zubron zubron merged commit c8dfd64 into vmware-tanzu:main Mar 15, 2021
@codegold79 codegold79 deleted the restore-progress-reporting-pr-bug-fix branch March 17, 2021 15:17
@pranavgaikwad
Copy link
Contributor

@codegold79 Thank you very much for the fix. I may have missed this in the rebase, both PRs (yours and mine) were merged around the same time. Sorry about that. I was unavailable last two weeks. Couldn't look at the issue. Thank you again!

dharmab pushed a commit to dharmab/velero that referenced this pull request May 25, 2021
@codegold79 @dharmab
Restore progress reporting bug fix (vmware-tanzu#3583)
4821408 
* Improve readbility and formatting of pkg/restore/restore.go

Signed-off-by: F. Gold <[email protected]>

* Update paths to include API group versions

Signed-off-by: F. Gold <[email protected]>

* Use full word, 'resource' instead of 'resrc'

Signed-off-by: F. Gold <[email protected]>
ywk253100 pushed a commit to ywk253100/velero that referenced this pull request Jun 29, 2021
@codegold79 @ywk253100
Restore progress reporting bug fix (vmware-tanzu#3583)
109a130 
* Improve readbility and formatting of pkg/restore/restore.go

Signed-off-by: F. Gold <[email protected]>

* Update paths to include API group versions

Signed-off-by: F. Gold <[email protected]>

* Use full word, 'resource' instead of 'resrc'

Signed-off-by: F. Gold <[email protected]>
gyaozhou pushed a commit to gyaozhou/velero-read that referenced this pull request May 14, 2022
@codegold79 @gyaozhou
Restore progress reporting bug fix (vmware-tanzu#3583)
c2a6bbb 
* Improve readbility and formatting of pkg/restore/restore.go

Signed-off-by: F. Gold <[email protected]>

* Update paths to include API group versions

Signed-off-by: F. Gold <[email protected]>

* Use full word, 'resource' instead of 'resrc'

Signed-off-by: F. Gold <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zubron zubron zubron approved these changes

@carlisia carlisia carlisia approved these changes

Assignees

@codegold79 codegold79

Labels
kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PR 3125 Breaks API Group Versions Feature (PR 3133)
4 participants
@codegold79 @zubron @carlisia @pranavgaikwad