Add E2E test for multiple credentials #3559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/kind changelog-not-required |
github-actions
bot
added
Dependencies
zubron
added
P1 - Important
kind/release-blocker
github-actions
bot
added
the
kind/changelog-not-required
zubron
force-pushed
the
add-e2e-test-for-multi-creds
branch
from
2b8bc49 to
3b969b0
Compare
zubron
force-pushed
the
add-e2e-test-for-multi-creds
branch
from
3b969b0 to
3e1b2a5
Compare
This change adds an E2E test which exercises the mulitple credentials feature added in vmware-tanzu#3489. The test creates a secret from the given credentials and creates a BackupStorageLocation which uses those credentials. A backup and restore is then performed to the default BSL and to the newly created BSL. This change adds new flags to the E2E test suite to configure the BSL created and used in the test. Signed-off-by: Bridget McErlean <[email protected]>
zubron
force-pushed
the
add-e2e-test-for-multi-creds
branch
from
3e1b2a5 to
9ad1e89
Compare
carlisia
reviewed
Mar 10, 2021
test/e2e/backup_test.go
Outdated
| "Failed to successfully backup and restore Kibishii namespace") | ||
| }) | ||
|
|
||
| It("should successfully back up and restore to multiple BackupStorageLocations with unique credentials", func() { |
There was a problem hiding this comment.
This test name could be more precise and helpful. By itself it is not operating with multiple BSLs, only an additional one besides the existing default. So maybe if it's named "should successfully back up and restore to an additional BackupStorageLocation with unique credentials" it'd avoid people looking for more than one BSL being used in this test (I have no idea who'd do that... maybe me :) ).
These are such nits:
s/additionalBsl/additionalBSL
s/additionalBslCredentials/additionalBSLCredentials
s/additionalBslBucket/additionalBSLBucket
etc
Thank you.
Signed-off-by: Bridget McErlean <[email protected]>
dsu-igeek
approved these changes
Mar 10, 2021
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add a summary of your change
This change adds an E2E test which exercises the mulitple credentials
feature added in #3489. The test creates a secret from the given
credentials and creates a BackupStorageLocation which uses those
credentials. A backup and restore is then performed to the default
BSL and to the newly created BSL.
This change adds new flags to the E2E test suite to configure the BSL
created and used in the test.
Signed-off-by: Bridget McErlean [email protected]
Does your change fix a particular issue?
Part of #3304
Please indicate you've done the following:
/kind changelog-not-required.site/content/docs/main.