issue: add flag to the schedule cmd to configure the useOwnerReferencesInBackup option #3176
#3182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: matheusjuvelino <[email protected]>
github-actions
bot
requested review from
ashish-amarnath,
carlisia,
dsu-igeek,
nrb and
zubron
Signed-off-by: matheusjuvelino <[email protected]>
zubron
suggested changes
Dec 14, 2020
pkg/cmd/cli/schedule/create.go
Outdated
| @@ -94,6 +95,7 @@ func NewCreateOptions() *CreateOptions { | |||
| func (o *CreateOptions) BindFlags(flags *pflag.FlagSet) { | |||
| o.BackupOptions.BindFlags(flags) | |||
| flags.StringVar(&o.Schedule, "schedule", o.Schedule, "a cron expression specifying a recurring schedule for this backup to run") | |||
| flags.BoolVar(&o.UseOwnerReferencesInBackup, "use-owner-rferences-in-backup", o.UseOwnerReferencesInBackup, "specifies whether to use OwnerReferences on backups created by this Schedule") | |||
There was a problem hiding this comment.
There is a typo in this flag, it should be "use-owner-references-in-backup".
There was a problem hiding this comment.
yes, sorry for my mistake.
…backup Signed-off-by: matheusjuvelino <[email protected]>
zubron
approved these changes
Dec 14, 2020
nrb
approved these changes
Dec 15, 2020
georgettica
pushed a commit
to georgettica/velero
that referenced
this pull request
Dec 23, 2020
…cesInBackup` option vmware-tanzu#3176 (vmware-tanzu#3182) * resolve: vmware-tanzu#3176 Signed-off-by: matheusjuvelino <[email protected]> * created changelog Signed-off-by: matheusjuvelino <[email protected]> * fixed use-owner-rferences-in-backup flag for use-owner-references-in-backup Signed-off-by: matheusjuvelino <[email protected]>
georgettica
pushed a commit
to georgettica/velero
that referenced
this pull request
Jan 26, 2021
…cesInBackup` option vmware-tanzu#3176 (vmware-tanzu#3182) * resolve: vmware-tanzu#3176 Signed-off-by: matheusjuvelino <[email protected]> * created changelog Signed-off-by: matheusjuvelino <[email protected]> * fixed use-owner-rferences-in-backup flag for use-owner-references-in-backup Signed-off-by: matheusjuvelino <[email protected]>
vadasambar
pushed a commit
to vadasambar/velero
that referenced
this pull request
Feb 3, 2021
…cesInBackup` option vmware-tanzu#3176 (vmware-tanzu#3182) * resolve: vmware-tanzu#3176 Signed-off-by: matheusjuvelino <[email protected]> * created changelog Signed-off-by: matheusjuvelino <[email protected]> * fixed use-owner-rferences-in-backup flag for use-owner-references-in-backup Signed-off-by: matheusjuvelino <[email protected]>
dharmab
pushed a commit
to dharmab/velero
that referenced
this pull request
May 25, 2021
…cesInBackup` option vmware-tanzu#3176 (vmware-tanzu#3182) * resolve: vmware-tanzu#3176 Signed-off-by: matheusjuvelino <[email protected]> * created changelog Signed-off-by: matheusjuvelino <[email protected]> * fixed use-owner-rferences-in-backup flag for use-owner-references-in-backup Signed-off-by: matheusjuvelino <[email protected]>
ywk253100
pushed a commit
to ywk253100/velero
that referenced
this pull request
Jun 29, 2021
…cesInBackup` option vmware-tanzu#3176 (vmware-tanzu#3182) * resolve: vmware-tanzu#3176 Signed-off-by: matheusjuvelino <[email protected]> * created changelog Signed-off-by: matheusjuvelino <[email protected]> * fixed use-owner-rferences-in-backup flag for use-owner-references-in-backup Signed-off-by: matheusjuvelino <[email protected]>
gyaozhou
pushed a commit
to gyaozhou/velero-read
that referenced
this pull request
May 14, 2022
…cesInBackup` option vmware-tanzu#3176 (vmware-tanzu#3182) * resolve: vmware-tanzu#3176 Signed-off-by: matheusjuvelino <[email protected]> * created changelog Signed-off-by: matheusjuvelino <[email protected]> * fixed use-owner-rferences-in-backup flag for use-owner-references-in-backup Signed-off-by: matheusjuvelino <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3176
Signed-off-by: matheusjuvelino [email protected]