Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tencent S3 Compatible Support Docs #3115

Merged
merged 5 commits into from
Dec 11, 2020
Merged

Conversation

imjokey
Copy link
Contributor

@imjokey imjokey commented Nov 26, 2020

Add Tencent Cloud S3-Compatible object store providers Support Docs

Signed-off-by: jokeyli <[email protected]>
Signed-off-by: jokeyli <[email protected]>
Copy link
Contributor

@nrb nrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the documentation @imjokey! This is great! I have a few suggested changes.

changelogs/unreleased/3115-imjokey Outdated Show resolved Hide resolved
site/content/docs/main/contributions/tencent-config.md Outdated Show resolved Hide resolved
@nrb nrb requested a review from a-mccarthy November 30, 2020 19:28
Copy link
Contributor

@a-mccarthy a-mccarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through and added some wording suggestions based on the Velero style guide, https://velero.io/docs/v1.5/style-guide/.

---


You can deploy Velero on Tencent [TKE](https://console.cloud.tencent.com/tke2/) , or even on any other Kubernetes cluster, but anyway you can use Tencent Cloud Object Store as a destination for Velero’s backups.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: "You can deploy Velero on Tencent TKE, or an other Kubernetes cluster, and use Tencent Cloud Object Store as a destination for Velero’s backups."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank u, I will fixed it.


- Registered [Tencent Cloud Account](https://cloud.tencent.com/register).
- Tencent Cloud COS service, referred to as COS, has been launched.
- A Kubernetes cluster has been created, cluster version v1.10 or later, and the cluster can use DNS and Internet services normally. If you need to create a TKE cluster, Please refer to [Create a cluster](https://cloud.tencent.com/document/product/457/32189).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: "If you need to create a TKE cluster, refer to the Tencent create a cluster documentation."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank u, I will fixed it.


## Create a Tencent cloud COS bucket

Create an object bucket for Velero to store backups in the Tencent Cloud COS console. About how to create a bucket, please refer to Tencent Cloud COS [Create a bucket](https://cloud.tencent.com/document/product/436/13309) usage instructions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion to replace "About how to create.." with "For how to create..."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank u, I will fixed it.


Create an object bucket for Velero to store backups in the Tencent Cloud COS console. About how to create a bucket, please refer to Tencent Cloud COS [Create a bucket](https://cloud.tencent.com/document/product/436/13309) usage instructions.

Set access to the bucket through the object storage console, the bucket needs to be **read** and **written**, so the account is granted data reading, data writing permissions, About how to configure See [Permission Access Settings](https://cloud.tencent.com/document/product/436/13315.E5.8D.95.E4.B8.AA.E6.8E.88.E6.9D.83).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Set access to the bucket through the object storage console, the bucket needs to be read and written, so the account is granted data reading, data writing permissions. For how to configure, see the permission access settings Tencent user instructions."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank u, I will fixed it.


## Get bucket access credentials

Velero uses an AWS S3-compatible API to access Tencent Cloud COS storage, which requires authentication using a pair of access key IDs and key-created signatures, and in the S3 API parameter, the "access_key_id" field is the access key ID and the "secret_access_key" field is the key.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make this two sentences, "Velero uses an AWS S3-compatible API to access Tencent Cloud COS storage, which requires authentication using a pair of access key IDs and key-created signatures. In the S3 API parameter, the "access_key_id" field is the access key ID and the "secret_access_key" field is the key. "

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank u, I will fixed it.


{{< figure src="https://main.qcloudimg.com/raw/e932223585c0b19891cc085ad7f438e1.png" width="100%">}}

With Velero Backup, you can back up all objects in the cluster directly, or filter objects by type, namespace, and/or label, and in this example I use the following command to back up only all resources under the 'default' namespace:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion - "With Velero Backup, you can back up all objects in the cluster directly, or filter objects by type, namespace, and/or label. This example uses the following command to back up all resources under the 'default' namespace."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank u, I will fixed it.

{{< figure src="https://main.qcloudimg.com/raw/eb2bbabae48b188748f5278bedf177f1.png" width="100%">}}


At this point we delete all of minio's resources, including its PVC persistence volume, as shown below:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion - "At this point delete all of MinIO's resources, including its PVC persistence volume, as shown below:"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank u, I will fixed it.


{{< figure src="https://main.qcloudimg.com/raw/15ccaacf00640a04ae29ceed4c86195b.png" width="100%">}}

After deleting the minio resource, we can test using the previous backup to restore the deleted minio resource, and temporarily update the backup storage location to read-only mode (this prevents the backup object from being created or deleted in the backup storage location during the restore process):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion - "After deleting the MinIO resource, use your backup to restore the deleted MinIO resource, and temporarily update the backup storage location to read-only mode (this prevents the backup object from being created or deleted in the backup storage location during the restore process):"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank u, I will fixed it.


```

Modifying access to velero's storage location is "ReadOnly," as shown in the following image:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to capitalize Velero here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank u, I will fixed it.


In the cluster, use the helm tool to create a minio test service with a persistent volume, and the minio installation method can be found in the [minio installation](https://github.com/minio/charts), in which case I have bound a load balancer for the minio service to access the management page using a public address in the browser.

{{< figure src="https://main.qcloudimg.com/raw/f0fff5228527edc72d6e71a50d5dc966.png" width="100%">}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add these images to the velero repo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, but I have the following confusion:

  1. Which directory should I put the picture in? /docs/main/img?
  2. Since I need to customize the width of the picture, I use figure shortcodde, the local link makes it impossible for me to get to src. I don't know how to fix it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been solved the second confusion,thank u very much.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also create a directory "contributions/img-for-tencent" for put the images to solve the first confusion.

@github-actions github-actions bot requested a review from nrb December 1, 2020 06:40
@imjokey imjokey force-pushed the s3-compatible-docs branch from f5b4d3f to 5194ea2 Compare December 1, 2020 06:51
Signed-off-by: jokeyli <[email protected]>
@imjokey imjokey force-pushed the s3-compatible-docs branch from 5194ea2 to 62544f2 Compare December 1, 2020 06:54
@imjokey imjokey requested a review from a-mccarthy December 9, 2020 13:04
carlisia
carlisia previously approved these changes Dec 11, 2020
Copy link
Contributor

@carlisia carlisia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm 👍

@carlisia carlisia dismissed their stale review December 11, 2020 17:27

We are getting some CHMOD warnings from the Hugo server output, I'm investigating.

@carlisia
Copy link
Contributor

Weird. I was getting one of these for each of the new images:

INFO 2020/12/11 09:41:16 Received System Events: ["/Users/carlisiac/work/src/github.com/vmware-tanzu/velero/site/content/docs/v1.5/contributions/img-for-tencent/15ccaacf00640a04ae29ceed4c86195b.png": CHMOD 

but moved some stuff around and these messages stopped.

Copy link
Contributor

@carlisia carlisia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@nrb nrb changed the title Tencent S3 Compatible Surpport Docs Tencent S3 Compatible Support Docs Dec 11, 2020
@nrb nrb merged commit 2f635e1 into vmware-tanzu:main Dec 11, 2020
georgettica pushed a commit to georgettica/velero that referenced this pull request Dec 23, 2020
* Tencent S3 Compatible Surpport Docs

Signed-off-by: jokeyli <[email protected]>

* fixed typos & and CHANGELOG log

Signed-off-by: jokeyli <[email protected]>

* add changelog

Signed-off-by: jokeyli <[email protected]>

* add changelog

Signed-off-by: jokeyli <[email protected]>

* fixed suggestions

Signed-off-by: jokeyli <[email protected]>
georgettica pushed a commit to georgettica/velero that referenced this pull request Jan 26, 2021
* Tencent S3 Compatible Surpport Docs

Signed-off-by: jokeyli <[email protected]>

* fixed typos & and CHANGELOG log

Signed-off-by: jokeyli <[email protected]>

* add changelog

Signed-off-by: jokeyli <[email protected]>

* add changelog

Signed-off-by: jokeyli <[email protected]>

* fixed suggestions

Signed-off-by: jokeyli <[email protected]>
vadasambar pushed a commit to vadasambar/velero that referenced this pull request Feb 3, 2021
* Tencent S3 Compatible Surpport Docs

Signed-off-by: jokeyli <[email protected]>

* fixed typos & and CHANGELOG log

Signed-off-by: jokeyli <[email protected]>

* add changelog

Signed-off-by: jokeyli <[email protected]>

* add changelog

Signed-off-by: jokeyli <[email protected]>

* fixed suggestions

Signed-off-by: jokeyli <[email protected]>
dharmab pushed a commit to dharmab/velero that referenced this pull request May 25, 2021
* Tencent S3 Compatible Surpport Docs

Signed-off-by: jokeyli <[email protected]>

* fixed typos & and CHANGELOG log

Signed-off-by: jokeyli <[email protected]>

* add changelog

Signed-off-by: jokeyli <[email protected]>

* add changelog

Signed-off-by: jokeyli <[email protected]>

* fixed suggestions

Signed-off-by: jokeyli <[email protected]>
ywk253100 pushed a commit to ywk253100/velero that referenced this pull request Jun 29, 2021
* Tencent S3 Compatible Surpport Docs

Signed-off-by: jokeyli <[email protected]>

* fixed typos & and CHANGELOG log

Signed-off-by: jokeyli <[email protected]>

* add changelog

Signed-off-by: jokeyli <[email protected]>

* add changelog

Signed-off-by: jokeyli <[email protected]>

* fixed suggestions

Signed-off-by: jokeyli <[email protected]>
gyaozhou pushed a commit to gyaozhou/velero-read that referenced this pull request May 14, 2022
* Tencent S3 Compatible Surpport Docs

Signed-off-by: jokeyli <[email protected]>

* fixed typos & and CHANGELOG log

Signed-off-by: jokeyli <[email protected]>

* add changelog

Signed-off-by: jokeyli <[email protected]>

* add changelog

Signed-off-by: jokeyli <[email protected]>

* fixed suggestions

Signed-off-by: jokeyli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants