Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add delete sub-command for backup-location #3073

Merged
merged 7 commits into from
Nov 30, 2020
Merged

feat: add delete sub-command for backup-location #3073

merged 7 commits into from
Nov 30, 2020

Conversation

jenting
Copy link
Contributor

@jenting jenting commented Nov 13, 2020 •
edited
Loading

fixes #2168

  1. Add delete sub-command for BSL, list available sub-commands
velero backup-location delete <NAME>

or

velero delete backup-location <NAME>
velero delete backup-locations <NAME>
  1. Fix use label selector to get BSL doesn't work.
  2. Makes the --help message format alignments.

@jenting jenting changed the title feat: add delete sub-command to backup-location feat: add delete sub-command for backup-location Nov 13, 2020
@jenting jenting marked this pull request as ready for review November 13, 2020 08:00
@jenting jenting marked this pull request as draft November 13, 2020 09:26
@jenting jenting marked this pull request as draft November 13, 2020 09:26
@jenting jenting marked this pull request as draft November 13, 2020 09:26
@jenting jenting changed the title feat: add delete sub-command for backup-location wip: feat: add delete sub-command for backup-location Nov 13, 2020
@jenting jenting changed the title wip: feat: add delete sub-command for backup-location feat: add delete sub-command for backup-location Nov 16, 2020
@jenting jenting marked this pull request as ready for review November 16, 2020 02:59
@carlisia carlisia added this to the v1.6.0 milestone Nov 19, 2020
carlisia
carlisia suggested changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@carlisia carlisia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great add, thank you! I tested it and it works, but I do have a request to use the new api calls.

pkg/cmd/cli/backuplocation/delete.go Outdated Show resolved Hide resolved
JenTing Hsiao added 2 commits November 20, 2020 12:38
@github-actions github-actions bot requested a review from carlisia November 20, 2020 04:39
JenTing Hsiao added 3 commits November 20, 2020 12:40
Update changelog
fec180b 
Signed-off-by: JenTing Hsiao <[email protected]>
Ordering by alphabet
7e3c64d 
Signed-off-by: JenTing Hsiao <[email protected]>
Better example format for help message
2390ba0 
Signed-off-by: JenTing Hsiao <[email protected]>
@github-actions github-actions bot requested a review from dsu-igeek November 20, 2020 05:02
Capital the comments
752f52b 
Signed-off-by: JenTing Hsiao <[email protected]>
@jenting
Copy link
Contributor Author

jenting commented Nov 20, 2020

This is ready to be reviewed.

carlisia
carlisia approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@carlisia carlisia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this and it works as intended. Thank you for this contribution!

@nrb nrb merged commit 7f2de65 into vmware-tanzu:main Nov 30, 2020
@jenting jenting deleted the feat-delete-backup-location branch December 1, 2020 00:52
@georgettica georgettica mentioned this pull request Dec 23, 2020
Closed
georgettica pushed a commit to georgettica/velero that referenced this pull request Dec 23, 2020
@georgettica
feat: add delete sub-command for backup-location (vmware-tanzu#3073)
4a9995f 
* feat: add delete sub-command for backup-location

Signed-off-by: JenTing Hsiao <[email protected]>

* Change to use kubebuilder/runtimecontroller API

Signed-off-by: JenTing Hsiao <[email protected]>

* fix get BSL by label doesn't work

Signed-off-by: JenTing Hsiao <[email protected]>

* Update changelog

Signed-off-by: JenTing Hsiao <[email protected]>

* Ordering by alphabet

Signed-off-by: JenTing Hsiao <[email protected]>

* Better example format for help message

Signed-off-by: JenTing Hsiao <[email protected]>

* Capital the comments

Signed-off-by: JenTing Hsiao <[email protected]>
@carlisia carlisia mentioned this pull request Jan 13, 2021
Closed
georgettica pushed a commit to georgettica/velero that referenced this pull request Jan 26, 2021
@georgettica
feat: add delete sub-command for backup-location (vmware-tanzu#3073)
7cc1509 
* feat: add delete sub-command for backup-location

Signed-off-by: JenTing Hsiao <[email protected]>

* Change to use kubebuilder/runtimecontroller API

Signed-off-by: JenTing Hsiao <[email protected]>

* fix get BSL by label doesn't work

Signed-off-by: JenTing Hsiao <[email protected]>

* Update changelog

Signed-off-by: JenTing Hsiao <[email protected]>

* Ordering by alphabet

Signed-off-by: JenTing Hsiao <[email protected]>

* Better example format for help message

Signed-off-by: JenTing Hsiao <[email protected]>

* Capital the comments

Signed-off-by: JenTing Hsiao <[email protected]>
vadasambar pushed a commit to vadasambar/velero that referenced this pull request Feb 3, 2021
feat: add delete sub-command for backup-location (vmware-tanzu#3073)
71f44c0 
* feat: add delete sub-command for backup-location

Signed-off-by: JenTing Hsiao <[email protected]>

* Change to use kubebuilder/runtimecontroller API

Signed-off-by: JenTing Hsiao <[email protected]>

* fix get BSL by label doesn't work

Signed-off-by: JenTing Hsiao <[email protected]>

* Update changelog

Signed-off-by: JenTing Hsiao <[email protected]>

* Ordering by alphabet

Signed-off-by: JenTing Hsiao <[email protected]>

* Better example format for help message

Signed-off-by: JenTing Hsiao <[email protected]>

* Capital the comments

Signed-off-by: JenTing Hsiao <[email protected]>
dharmab pushed a commit to dharmab/velero that referenced this pull request May 25, 2021
@dharmab
feat: add delete sub-command for backup-location (vmware-tanzu#3073)
ece322d 
* feat: add delete sub-command for backup-location

Signed-off-by: JenTing Hsiao <[email protected]>

* Change to use kubebuilder/runtimecontroller API

Signed-off-by: JenTing Hsiao <[email protected]>

* fix get BSL by label doesn't work

Signed-off-by: JenTing Hsiao <[email protected]>

* Update changelog

Signed-off-by: JenTing Hsiao <[email protected]>

* Ordering by alphabet

Signed-off-by: JenTing Hsiao <[email protected]>

* Better example format for help message

Signed-off-by: JenTing Hsiao <[email protected]>

* Capital the comments

Signed-off-by: JenTing Hsiao <[email protected]>
ywk253100 pushed a commit to ywk253100/velero that referenced this pull request Jun 29, 2021
@ywk253100
feat: add delete sub-command for backup-location (vmware-tanzu#3073)
8a83fd1 
* feat: add delete sub-command for backup-location

Signed-off-by: JenTing Hsiao <[email protected]>

* Change to use kubebuilder/runtimecontroller API

Signed-off-by: JenTing Hsiao <[email protected]>

* fix get BSL by label doesn't work

Signed-off-by: JenTing Hsiao <[email protected]>

* Update changelog

Signed-off-by: JenTing Hsiao <[email protected]>

* Ordering by alphabet

Signed-off-by: JenTing Hsiao <[email protected]>

* Better example format for help message

Signed-off-by: JenTing Hsiao <[email protected]>

* Capital the comments

Signed-off-by: JenTing Hsiao <[email protected]>
gyaozhou pushed a commit to gyaozhou/velero-read that referenced this pull request May 14, 2022
@gyaozhou
feat: add delete sub-command for backup-location (vmware-tanzu#3073)
6d15b05 
* feat: add delete sub-command for backup-location

Signed-off-by: JenTing Hsiao <[email protected]>

* Change to use kubebuilder/runtimecontroller API

Signed-off-by: JenTing Hsiao <[email protected]>

* fix get BSL by label doesn't work

Signed-off-by: JenTing Hsiao <[email protected]>

* Update changelog

Signed-off-by: JenTing Hsiao <[email protected]>

* Ordering by alphabet

Signed-off-by: JenTing Hsiao <[email protected]>

* Better example format for help message

Signed-off-by: JenTing Hsiao <[email protected]>

* Capital the comments

Signed-off-by: JenTing Hsiao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrb nrb nrb approved these changes

@carlisia carlisia carlisia approved these changes

@ashish-amarnath ashish-amarnath Awaiting requested review from ashish-amarnath

@zubron zubron Awaiting requested review from zubron

@dsu-igeek dsu-igeek Awaiting requested review from dsu-igeek

Assignees

@jenting jenting

Labels
None yet
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

No cli option to delete a backup location (Velero 1.1.0)
3 participants
@jenting @carlisia @nrb