Adding fix for restic init container index on restores. #3011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doughepi
force-pushed
the
initcontainerorder
branch
from
d5f83f1 to
c86a89b
Compare
Signed-off-by: Piper Dougherty <[email protected]>
doughepi
force-pushed
the
initcontainerorder
branch
from
c86a89b to
1119e2d
Compare
added 2 commits
October 15, 2020 23:27
Signed-off-by: Piper Dougherty <[email protected]>
Signed-off-by: Piper Dougherty <[email protected]>
github-actions
bot
requested review from
ashish-amarnath,
carlisia,
nrb and
zubron
Signed-off-by: Piper Dougherty <[email protected]>
nrb
approved these changes
Oct 20, 2020
There was a problem hiding this comment.
Thanks for the bug report and the fix! This makes a lot of sense to me, and I definitely agree with having a warning instead of silently failing.
The ramifications of not being first in all cases is a little hard to predict as we don't know what might mutate the pod, but I think this is more correct than the previous behavior.
ashish-amarnath
approved these changes
Oct 21, 2020
jenting
reviewed
Nov 4, 2020
Comment on lines
+675
to
+695
| { | ||
| name: "pod with restic init container as first initContainer should return 0", | ||
| pod: &corev1api.Pod{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Namespace: "ns-1", | ||
| Name: "pod-1", | ||
| }, | ||
| Spec: corev1api.PodSpec{ | ||
| InitContainers: []corev1api.Container{ | ||
| { | ||
| Name: restic.InitContainer, | ||
| }, | ||
| { | ||
| Name: "non-restic-init", | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| expected: 0, | ||
| }, | ||
| } |
There was a problem hiding this comment.
@doughepi It's a duplicated test case 😃
georgettica
pushed a commit
to georgettica/velero
that referenced
this pull request
Dec 23, 2020
…#3011) * Adding handling of restic-wait init container at any order with warning. Signed-off-by: Piper Dougherty <[email protected]> * Adding newline at end of files to match convention. Signed-off-by: Piper Dougherty <[email protected]> * Formatting. Signed-off-by: Piper Dougherty <[email protected]> * Update copyright year on modified files. Signed-off-by: Piper Dougherty <[email protected]>
zubron
pushed a commit
that referenced
this pull request
Jan 14, 2021
* Adding handling of restic-wait init container at any order with warning. Signed-off-by: Piper Dougherty <[email protected]> * Adding newline at end of files to match convention. Signed-off-by: Piper Dougherty <[email protected]> * Formatting. Signed-off-by: Piper Dougherty <[email protected]> * Update copyright year on modified files. Signed-off-by: Piper Dougherty <[email protected]>
georgettica
pushed a commit
to georgettica/velero
that referenced
this pull request
Jan 26, 2021
…#3011) * Adding handling of restic-wait init container at any order with warning. Signed-off-by: Piper Dougherty <[email protected]> * Adding newline at end of files to match convention. Signed-off-by: Piper Dougherty <[email protected]> * Formatting. Signed-off-by: Piper Dougherty <[email protected]> * Update copyright year on modified files. Signed-off-by: Piper Dougherty <[email protected]>
vadasambar
pushed a commit
to vadasambar/velero
that referenced
this pull request
Feb 3, 2021
…#3011) * Adding handling of restic-wait init container at any order with warning. Signed-off-by: Piper Dougherty <[email protected]> * Adding newline at end of files to match convention. Signed-off-by: Piper Dougherty <[email protected]> * Formatting. Signed-off-by: Piper Dougherty <[email protected]> * Update copyright year on modified files. Signed-off-by: Piper Dougherty <[email protected]>
dharmab
pushed a commit
to dharmab/velero
that referenced
this pull request
May 25, 2021
…#3011) * Adding handling of restic-wait init container at any order with warning. Signed-off-by: Piper Dougherty <[email protected]> * Adding newline at end of files to match convention. Signed-off-by: Piper Dougherty <[email protected]> * Formatting. Signed-off-by: Piper Dougherty <[email protected]> * Update copyright year on modified files. Signed-off-by: Piper Dougherty <[email protected]>
ywk253100
pushed a commit
to ywk253100/velero
that referenced
this pull request
Jun 29, 2021
…#3011) * Adding handling of restic-wait init container at any order with warning. Signed-off-by: Piper Dougherty <[email protected]> * Adding newline at end of files to match convention. Signed-off-by: Piper Dougherty <[email protected]> * Formatting. Signed-off-by: Piper Dougherty <[email protected]> * Update copyright year on modified files. Signed-off-by: Piper Dougherty <[email protected]>
gyaozhou
pushed a commit
to gyaozhou/velero-read
that referenced
this pull request
May 14, 2022
…#3011) * Adding handling of restic-wait init container at any order with warning. Signed-off-by: Piper Dougherty <[email protected]> * Adding newline at end of files to match convention. Signed-off-by: Piper Dougherty <[email protected]> * Formatting. Signed-off-by: Piper Dougherty <[email protected]> * Update copyright year on modified files. Signed-off-by: Piper Dougherty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the
restic-waitinit container to exist in any order in the pod being restored. Prints a warning message in the case where therestic-waitcontainer isn't the first container in the list of initialization containers.As it stands right now, there's no indication that your restore is held up by the
restic-waitcontainer being anywhere other than the first initialization container. This attempts to complete the restore, and warns if therestic-waitcontainer is anywhere other than the first container.I believe this is the better strategy because there are many cases where—despite Velero's best effort—other containers will be injected before it. Our breaking example was the
istio-validatecontainer. Velero is correctly placing the initialization container at index 0, but the istio mutating webhook will always be evaluated after this. I believe all mutating webhooks that try to place their initialization containers at position 0 will break restores in the same manner.The warning serves to warn the user. I don't think initialization containers coming before the
restic-waitcontainer are an error state—just that they could affect the restore if they do something weird with the mounted volumes. Either way, I believe this behavior is better than a silent failure.fixes: #3008
Signed-off-by: Piper Dougherty [email protected]