-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.5 blog post #2940
v1.5 blog post #2940
Conversation
Signed-off-by: Ashish Amarnath <[email protected]>
Signed-off-by: Nolan Brubaker <[email protected]>
Since there's not really an easy way to use the preview URL environment variables in the netlify.toml, remove the baseURL argument entirely from the build command. Signed-off-by: Nolan Brubaker <[email protected]>
Blog looks good, just one minor change I'd like to see, and that's the date in the blog post. |
The link to upgrade to 1.5 is broken: https://velero.io/docs/v1.5/upgrade-to-1.5/ This works: https://deploy-preview-2940--velero.netlify.app/docs/v1.5.0-rc.1/upgrade-to-1.5/ Same for https://velero.io/docs/v1.5/restic/ Same for https://velero.io/docs/v1.5/backup-hooks/ Same for: https://github.com/vmware-tanzu/velero/blob/v1.5.0/changelogs/CHANGELOG-1.5.md |
1.5 isn't out yet so the docs aren't published for that version yet. |
Such a good point 😄 |
Updating the blog post date and the link to github to |
Signed-off-by: Nolan Brubaker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Per the release instructions, this gets merged after the release. |
* Blop post announcing Velero 1.5 Signed-off-by: Ashish Amarnath <[email protected]> * Remove hardcoded deploy preview URL Signed-off-by: Nolan Brubaker <[email protected]> * Remove base URL entirely Since there's not really an easy way to use the preview URL environment variables in the netlify.toml, remove the baseURL argument entirely from the build command. Signed-off-by: Nolan Brubaker <[email protected]> * Update blog post date and expected tag link Signed-off-by: Nolan Brubaker <[email protected]> Co-authored-by: Ashish Amarnath <[email protected]>
* Blop post announcing Velero 1.5 Signed-off-by: Ashish Amarnath <[email protected]> * Remove hardcoded deploy preview URL Signed-off-by: Nolan Brubaker <[email protected]> * Remove base URL entirely Since there's not really an easy way to use the preview URL environment variables in the netlify.toml, remove the baseURL argument entirely from the build command. Signed-off-by: Nolan Brubaker <[email protected]> * Update blog post date and expected tag link Signed-off-by: Nolan Brubaker <[email protected]> Co-authored-by: Ashish Amarnath <[email protected]>
* Blop post announcing Velero 1.5 Signed-off-by: Ashish Amarnath <[email protected]> * Remove hardcoded deploy preview URL Signed-off-by: Nolan Brubaker <[email protected]> * Remove base URL entirely Since there's not really an easy way to use the preview URL environment variables in the netlify.toml, remove the baseURL argument entirely from the build command. Signed-off-by: Nolan Brubaker <[email protected]> * Update blog post date and expected tag link Signed-off-by: Nolan Brubaker <[email protected]> Co-authored-by: Ashish Amarnath <[email protected]>
* Blop post announcing Velero 1.5 Signed-off-by: Ashish Amarnath <[email protected]> * Remove hardcoded deploy preview URL Signed-off-by: Nolan Brubaker <[email protected]> * Remove base URL entirely Since there's not really an easy way to use the preview URL environment variables in the netlify.toml, remove the baseURL argument entirely from the build command. Signed-off-by: Nolan Brubaker <[email protected]> * Update blog post date and expected tag link Signed-off-by: Nolan Brubaker <[email protected]> Co-authored-by: Ashish Amarnath <[email protected]>
* Blop post announcing Velero 1.5 Signed-off-by: Ashish Amarnath <[email protected]> * Remove hardcoded deploy preview URL Signed-off-by: Nolan Brubaker <[email protected]> * Remove base URL entirely Since there's not really an easy way to use the preview URL environment variables in the netlify.toml, remove the baseURL argument entirely from the build command. Signed-off-by: Nolan Brubaker <[email protected]> * Update blog post date and expected tag link Signed-off-by: Nolan Brubaker <[email protected]> Co-authored-by: Ashish Amarnath <[email protected]>
* Blop post announcing Velero 1.5 Signed-off-by: Ashish Amarnath <[email protected]> * Remove hardcoded deploy preview URL Signed-off-by: Nolan Brubaker <[email protected]> * Remove base URL entirely Since there's not really an easy way to use the preview URL environment variables in the netlify.toml, remove the baseURL argument entirely from the build command. Signed-off-by: Nolan Brubaker <[email protected]> * Update blog post date and expected tag link Signed-off-by: Nolan Brubaker <[email protected]> Co-authored-by: Ashish Amarnath <[email protected]>
Replacement for #2937 since I can't push to Ashish's remote.