Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.5 blog post #2940

Merged
merged 4 commits into from
Sep 16, 2020
Merged

v1.5 blog post #2940

merged 4 commits into from
Sep 16, 2020

Conversation

nrb
Copy link
Contributor

@nrb nrb commented Sep 16, 2020

Replacement for #2937 since I can't push to Ashish's remote.

ashish-amarnath and others added 2 commits September 16, 2020 09:58
@nrb nrb added the Website non-docs changes for the website label Sep 16, 2020
Since there's not really an easy way to use the preview URL environment
variables in the netlify.toml, remove the baseURL argument entirely
from the build command.

Signed-off-by: Nolan Brubaker <[email protected]>
@jonasrosland
Copy link
Contributor

Blog looks good, just one minor change I'd like to see, and that's the date in the blog post.

@carlisia
Copy link
Contributor

carlisia commented Sep 16, 2020

@jonasrosland
Copy link
Contributor

The link to upgrade to 1.5 is broken: https://velero.io/docs/v1.5/upgrade-to-1.5/

This works: https://deploy-preview-2940--velero.netlify.app/docs/v1.5.0-rc.1/upgrade-to-1.5/

1.5 isn't out yet so the docs aren't published for that version yet.

@carlisia
Copy link
Contributor

1.5 isn't out yet so the docs aren't published for that version yet.

Such a good point 😄

@nrb
Copy link
Contributor Author

nrb commented Sep 16, 2020

Updating the blog post date and the link to github to v1.5.1 since we'll be doing that tag instead of v1.5.0

Copy link
Contributor

@carlisia carlisia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nrb
Copy link
Contributor Author

nrb commented Sep 16, 2020

Per the release instructions, this gets merged after the release.

@nrb nrb merged commit b2ff7e6 into vmware-tanzu:main Sep 16, 2020
georgettica pushed a commit to georgettica/velero that referenced this pull request Dec 23, 2020
* Blop post announcing Velero 1.5

Signed-off-by: Ashish Amarnath <[email protected]>

* Remove hardcoded deploy preview URL

Signed-off-by: Nolan Brubaker <[email protected]>

* Remove base URL entirely

Since there's not really an easy way to use the preview URL environment
variables in the netlify.toml, remove the baseURL argument entirely
from the build command.

Signed-off-by: Nolan Brubaker <[email protected]>

* Update blog post date and expected tag link

Signed-off-by: Nolan Brubaker <[email protected]>

Co-authored-by: Ashish Amarnath <[email protected]>
georgettica pushed a commit to georgettica/velero that referenced this pull request Jan 26, 2021
* Blop post announcing Velero 1.5

Signed-off-by: Ashish Amarnath <[email protected]>

* Remove hardcoded deploy preview URL

Signed-off-by: Nolan Brubaker <[email protected]>

* Remove base URL entirely

Since there's not really an easy way to use the preview URL environment
variables in the netlify.toml, remove the baseURL argument entirely
from the build command.

Signed-off-by: Nolan Brubaker <[email protected]>

* Update blog post date and expected tag link

Signed-off-by: Nolan Brubaker <[email protected]>

Co-authored-by: Ashish Amarnath <[email protected]>
vadasambar pushed a commit to vadasambar/velero that referenced this pull request Feb 3, 2021
* Blop post announcing Velero 1.5

Signed-off-by: Ashish Amarnath <[email protected]>

* Remove hardcoded deploy preview URL

Signed-off-by: Nolan Brubaker <[email protected]>

* Remove base URL entirely

Since there's not really an easy way to use the preview URL environment
variables in the netlify.toml, remove the baseURL argument entirely
from the build command.

Signed-off-by: Nolan Brubaker <[email protected]>

* Update blog post date and expected tag link

Signed-off-by: Nolan Brubaker <[email protected]>

Co-authored-by: Ashish Amarnath <[email protected]>
dharmab pushed a commit to dharmab/velero that referenced this pull request May 25, 2021
* Blop post announcing Velero 1.5

Signed-off-by: Ashish Amarnath <[email protected]>

* Remove hardcoded deploy preview URL

Signed-off-by: Nolan Brubaker <[email protected]>

* Remove base URL entirely

Since there's not really an easy way to use the preview URL environment
variables in the netlify.toml, remove the baseURL argument entirely
from the build command.

Signed-off-by: Nolan Brubaker <[email protected]>

* Update blog post date and expected tag link

Signed-off-by: Nolan Brubaker <[email protected]>

Co-authored-by: Ashish Amarnath <[email protected]>
ywk253100 pushed a commit to ywk253100/velero that referenced this pull request Jun 29, 2021
* Blop post announcing Velero 1.5

Signed-off-by: Ashish Amarnath <[email protected]>

* Remove hardcoded deploy preview URL

Signed-off-by: Nolan Brubaker <[email protected]>

* Remove base URL entirely

Since there's not really an easy way to use the preview URL environment
variables in the netlify.toml, remove the baseURL argument entirely
from the build command.

Signed-off-by: Nolan Brubaker <[email protected]>

* Update blog post date and expected tag link

Signed-off-by: Nolan Brubaker <[email protected]>

Co-authored-by: Ashish Amarnath <[email protected]>
gyaozhou pushed a commit to gyaozhou/velero-read that referenced this pull request May 14, 2022
* Blop post announcing Velero 1.5

Signed-off-by: Ashish Amarnath <[email protected]>

* Remove hardcoded deploy preview URL

Signed-off-by: Nolan Brubaker <[email protected]>

* Remove base URL entirely

Since there's not really an easy way to use the preview URL environment
variables in the netlify.toml, remove the baseURL argument entirely
from the build command.

Signed-off-by: Nolan Brubaker <[email protected]>

* Update blog post date and expected tag link

Signed-off-by: Nolan Brubaker <[email protected]>

Co-authored-by: Ashish Amarnath <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Website non-docs changes for the website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants