use restic stats instead of check to check repo existence #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlisia
reviewed
Feb 6, 2019
| @@ -162,10 +162,10 @@ func (c *resticRepositoryController) initializeRepo(req *v1.ResticRepository, lo | |||
| }) | |||
| } | |||
|
|
|||
| // ensureRepo first checks the repo, and returns if check passes. If it fails, | |||
| // ensureRepo first tries to connect to the repo, and returns if it succeeds. If it fails, | |||
| // attempts to init the repo, and returns the result. | |||
There was a problem hiding this comment.
Super nit pick: should be "it attempts".
carlisia
approved these changes
Feb 6, 2019
nrb
approved these changes
Feb 6, 2019
Signed-off-by: Steve Kriss <[email protected]>
|
addressed. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Steve Kriss [email protected]
The first time Velero is performing an operation against a restic repository, it first checks to see if the repo exists, and if not, it initializes it. Today, the way it checks if the repo exists is by running the
restic checkcommand with the right flags and auth, and sees if that succeeds.Turns out that this command can be quite slow the first time that it's run on a host/container that doesn't already have a local restic cache set up (e.g. in Cluster B's Velero pod in a Cluster A -> Cluster B migration). An alternate command,
restic stats, is much faster and also achieves the desired outcome of ensuring the restic repo exists and can be authenticated to.I've tested this manually and can replicate the slow behavior with the current code, and can confirm that the updated code is much faster.