Initialize empty schedule metrics on server init #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When backups are run manually (outside of a schedule) the metrics
will be counted for ark_*{schedule=""}. To prevent partial NaN
metrics they will be initialised on server init.
Signed-off-by: Christian Beneke <[email protected]>
|
Thanks for this @cbeneke! I'll take a closer look this afternoon, but my initial thought is that this makes sense. |
nrb
approved these changes
Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When backups are run manually (outside of a schedule) the metrics will be counted for
ark_*{schedule=""}. To prevent partialNaNmetrics they will be initialised on server init.The current behaviour creates e.g. only
ark_backup_failure_totalorark_backup_success_totalbut never both on the first manual run. Afaict thebackupNameshall be included in the metrics in the future, when this is implemented the initialisation must be moved to the point in time, where thebackupNameis already known (I guess theprocessBackup()function inpkg/controller/backup_controller.go), but so far the server init should be most sufficient for the metrics init.