Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

volumeClaimTemplates storageClassName in statefulsets incorrect after use Changing PV/PVC Storage Classes . #4373

Closed
Box-Cube opened this issue Nov 18, 2021 · 0 comments · Fixed by #4375
Assignees
Labels
Milestone

Comments

@Box-Cube
Copy link
Contributor

Box-Cube commented Nov 18, 2021

What steps did you take and what happened:
[A clear and concise description of what the bug is, and what commands you ran.)
when i used Changing PV/PVC Storage Classes function during restore,volumeClaimTemplates storageClassName in statefulsets not change. I get the volumeClaimTemplates storageClassName in the restored sts after restore completed,
i find It's still the old storageClassName.

What did you expect to happen:
when use Changing PV/PVC Storage Classes function, volumeClaimTemplates storageClassName in statefulsets should also be changed to use the new storageClassName .

The output of the following commands will help us better understand what's going on:
(Pasting long output into a GitHub gist or other pastebin is fine.)
kubectl get sts -n my-example web -oyaml --->
` volumeClaimTemplates:

  • apiVersion: v1
    kind: PersistentVolumeClaim
    metadata:
    name: www
    spec:
    accessModes:
    • ReadWriteOnce
      resources:
      requests:
      storage: 1Gi
      storageClassName: a-storage
      volumeMode: Filesystem`

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Velero version (v1.7.0):
  • Velero features ():
  • Kubernetes version (v1.20.9):

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "I would like to see this bug fixed as soon as possible"
  • 👎 for "There are more important bugs to focus on right now"
@Box-Cube Box-Cube changed the title volumeClaimTemplates in statefulsets incorrect after use Changing PV/PVC Storage Classes during restores. volumeClaimTemplates storageClassName in statefulsets incorrect after use Changing PV/PVC Storage Classes . Nov 18, 2021
@reasonerjt reasonerjt added the Bug label Nov 23, 2021
Box-Cube added a commit to Box-Cube/velero that referenced this issue Nov 28, 2021
Signed-off-by: Box-Cube <[email protected]>
Box-Cube added a commit to Box-Cube/velero that referenced this issue Nov 28, 2021
Box-Cube added a commit to Box-Cube/velero that referenced this issue Nov 28, 2021
Box-Cube added a commit to Box-Cube/velero that referenced this issue Nov 30, 2021
@ywk253100 ywk253100 added this to the v1.8.0 milestone Dec 15, 2021
Box-Cube added a commit to Box-Cube/velero that referenced this issue Dec 15, 2021
ywk253100 pushed a commit that referenced this issue Dec 16, 2021
…ging PV/PVC Storage Classes (#4375)

* fix statefulsets volumeClaimTemplates storageClassName after use Changing PV/PVC Storage Classes

Signed-off-by: Box-Cube <[email protected]>

* Fix (#4373)

Signed-off-by: Box-Cube <[email protected]>

* Fix StatefulSet volumeClaimTemplates storageClassName(#4373)

Signed-off-by: Box-Cube <[email protected]>

* Fix StatefulSet volumeClaimTemplates storageClassName(#4373)

Signed-off-by: Box-Cube <[email protected]>

* Fix StatefulSet volumeClaimTemplates storageClassName(#4373)

Signed-off-by: Box-Cube <[email protected]>

* Change the isStorageClassExist logic

Signed-off-by: Box-Cube <[email protected]>

* Fix StatefulSet volumeClaimTemplates storageClassName(#4373)

Signed-off-by: Box-Cube <[email protected]>
danfengliu pushed a commit to danfengliu/velero that referenced this issue Jan 25, 2022
…ging PV/PVC Storage Classes (vmware-tanzu#4375)

* fix statefulsets volumeClaimTemplates storageClassName after use Changing PV/PVC Storage Classes

Signed-off-by: Box-Cube <[email protected]>

* Fix (vmware-tanzu#4373)

Signed-off-by: Box-Cube <[email protected]>

* Fix StatefulSet volumeClaimTemplates storageClassName(vmware-tanzu#4373)

Signed-off-by: Box-Cube <[email protected]>

* Fix StatefulSet volumeClaimTemplates storageClassName(vmware-tanzu#4373)

Signed-off-by: Box-Cube <[email protected]>

* Fix StatefulSet volumeClaimTemplates storageClassName(vmware-tanzu#4373)

Signed-off-by: Box-Cube <[email protected]>

* Change the isStorageClassExist logic

Signed-off-by: Box-Cube <[email protected]>

* Fix StatefulSet volumeClaimTemplates storageClassName(vmware-tanzu#4373)

Signed-off-by: Box-Cube <[email protected]>
gyaozhou pushed a commit to gyaozhou/velero-read that referenced this issue May 14, 2022
…ging PV/PVC Storage Classes (vmware-tanzu#4375)

* fix statefulsets volumeClaimTemplates storageClassName after use Changing PV/PVC Storage Classes

Signed-off-by: Box-Cube <[email protected]>

* Fix (vmware-tanzu#4373)

Signed-off-by: Box-Cube <[email protected]>

* Fix StatefulSet volumeClaimTemplates storageClassName(vmware-tanzu#4373)

Signed-off-by: Box-Cube <[email protected]>

* Fix StatefulSet volumeClaimTemplates storageClassName(vmware-tanzu#4373)

Signed-off-by: Box-Cube <[email protected]>

* Fix StatefulSet volumeClaimTemplates storageClassName(vmware-tanzu#4373)

Signed-off-by: Box-Cube <[email protected]>

* Change the isStorageClassExist logic

Signed-off-by: Box-Cube <[email protected]>

* Fix StatefulSet volumeClaimTemplates storageClassName(vmware-tanzu#4373)

Signed-off-by: Box-Cube <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants