Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a warning to the velero version cmd when versions don't match #3017

Closed
carlisia opened this issue Oct 19, 2020 · 4 comments · Fixed by #3024
Closed

Add a warning to the velero version cmd when versions don't match #3017

carlisia opened this issue Oct 19, 2020 · 4 comments · Fixed by #3024
Assignees
@cvhariharan
Labels
Area/CLI related to the command-line interface Good first issue Looking to contribute to Velero? Issues with this label might be a great place to start! Help wanted

Comments

@carlisia
Copy link
Contributor

I've been seeing a few issues opened with a mismatch in version between Velero client and server. I think there's sufficient coupling between the two that it (the mismatch) could originate the problems being reported.

The velero version command should verify any mismatch and warn. Not sure how strong this warning should be. Should it be: "will not work, please update [whichever has the lower version]"?
@carlisia carlisia added Good first issue Looking to contribute to Velero? Issues with this label might be a great place to start! Help wanted Area/CLI related to the command-line interface labels Oct 19, 2020
@carlisia carlisia changed the title Add a warning to velero version when versions don't match Add a warning to the velero version cmd when versions don't match Oct 19, 2020
@cvhariharan
Copy link
Contributor

Hi, I can pick this up if this is up for grabs.

@carlisia
Copy link
Contributor Author

Yes, go for it!

@cvhariharan
Copy link
Contributor

Here, the warning should be thrown if the versions are not same for the cli and server right?

@carlisia
Copy link
Contributor Author

Yes. I think we should do the match on the minor version only, not the patch. Example: 1.4.1 and 1.4.2 would be a match.

cvhariharan added a commit to cvhariharan/velero that referenced this issue Oct 20, 2020
@cvhariharan
Add warning to velero version cmd. Fixes vmware-tanzu#3017
212da4b
cvhariharan added a commit to cvhariharan/velero that referenced this issue Oct 20, 2020
@cvhariharan
Add warning to velero version cmd. Fixes vmware-tanzu#3017
72bbe52 
Signed-off-by: Hariharan <[email protected]>
cvhariharan added a commit to cvhariharan/velero that referenced this issue Oct 20, 2020
@cvhariharan
Add warning to velero version cmd. Fixes vmware-tanzu#3017
ef81cb5 
Signed-off-by: Hariharan <[email protected]>
@nrb nrb mentioned this issue Oct 20, 2020
Merged
cvhariharan added a commit to cvhariharan/velero that referenced this issue Oct 21, 2020
@cvhariharan
Add warning to velero version cmd. Fixes vmware-tanzu#3017
0ad4787 
Signed-off-by: Hariharan <[email protected]>
zubron pushed a commit that referenced this issue Oct 23, 2020
@cvhariharan
Add warning to velero version cmd. Fixes #3017 (#3024)
df982c9 
Signed-off-by: Hariharan <[email protected]>
@georgettica georgettica mentioned this issue Dec 23, 2020
Closed
georgettica pushed a commit to georgettica/velero that referenced this issue Dec 23, 2020
@cvhariharan @georgettica
Add warning to velero version cmd. Fixes vmware-tanzu#3017 (vmware-ta…
9f2e05c 
…nzu#3024)

Signed-off-by: Hariharan <[email protected]>
georgettica pushed a commit to georgettica/velero that referenced this issue Jan 26, 2021
@cvhariharan @georgettica
Add warning to velero version cmd. Fixes vmware-tanzu#3017 (vmware-ta…
ad0fe0f 
…nzu#3024)

Signed-off-by: Hariharan <[email protected]>
vadasambar pushed a commit to vadasambar/velero that referenced this issue Feb 3, 2021
@cvhariharan
Add warning to velero version cmd. Fixes vmware-tanzu#3017 (vmware-ta…
2c2e8a6 
…nzu#3024)

Signed-off-by: Hariharan <[email protected]>
dharmab pushed a commit to dharmab/velero that referenced this issue May 25, 2021
@cvhariharan @dharmab
Add warning to velero version cmd. Fixes vmware-tanzu#3017 (vmware-ta…
ca40bc3 
…nzu#3024)

Signed-off-by: Hariharan <[email protected]>
ywk253100 pushed a commit to ywk253100/velero that referenced this issue Jun 29, 2021
@cvhariharan @ywk253100
Add warning to velero version cmd. Fixes vmware-tanzu#3017 (vmware-ta…
04bbd6f 
…nzu#3024)

Signed-off-by: Hariharan <[email protected]>
gyaozhou pushed a commit to gyaozhou/velero-read that referenced this issue May 14, 2022
@cvhariharan @gyaozhou
Add warning to velero version cmd. Fixes vmware-tanzu#3017 (vmware-ta…
b298bed 
…nzu#3024)

Signed-off-by: Hariharan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cvhariharan cvhariharan

Labels
Area/CLI related to the command-line interface Good first issue Looking to contribute to Velero? Issues with this label might be a great place to start! Help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add warning to velero version cmd. cvhariharan/velero
2 participants
@carlisia @cvhariharan