Check for empty ns list before checking nslist[0]

In determining whether a backup includes all namespaces, item_collector checks for an empty string in the first element of the ns list. If processing includes+excludes results in an empty list, treat this as another case of a not-all-namespaces backup rather than crashing velero. Signed-off-by: Scott Seago <[email protected]>
vmware-tanzu · Aug 19, 2022 · a8f7b20 · a8f7b20
1 parent b6cca3f
commit a8f7b20
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/pkg/backup/item_collector.go b/pkg/backup/item_collector.go
@@ -226,7 +226,7 @@ func (r *itemCollector) getResourceItems(log logrus.FieldLogger, gv schema.Group
 	namespacesToList := getNamespacesToList(r.backupRequest.NamespaceIncludesExcludes)
 
 	// Check if we're backing up namespaces, and only certain ones
-	if gr == kuberesource.Namespaces && namespacesToList[0] != "" {
+	if gr == kuberesource.Namespaces && (len(namespacesToList)== 0 || namespacesToList[0] != "") {
 		resourceClient, err := r.dynamicFactory.ClientForGroupVersionResource(gv, resource, "")
 		if err != nil {
 			log.WithError(err).Error("Error getting dynamic client")