-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
velero vSphere plugin docs for v1.3.0 #420
Conversation
Sorry, some of the pre-check tests are failing for this PR ! Please check the Jenkins job for more details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A general comment here. I would suggest to add a separate page for the detail of creating the ConfigMap with credential. In the cluster flavor specific landing page, let's add one entry into the list of prerequisites with EMPHASIS.
Actually, the ConfigMaps are different for guest and vanilla (no vc credentials secret necessary for guest), so having a common config map page wouldn't be possible. |
Just maintain different sections in the separate page for vanilla and guest cluster flavor respectively. Otherwise, if put too many detail in the per-cluster landing page, users are easy to get lost. |
Congratulations !! All the pre-check tests passed |
@deepakkinni I took one another look at this PR. Ignore my previous comments. Generally, it looks good to organize this newly added section this way. My only comment here is, would it be better to also add a corresponding section to supervisor.md and call out that it is not required to create such a ConfigMap for plugin in supervisor cluster? |
Signed-off-by: Deepak Kinni <[email protected]>
LGTM |
Congratulations !! All the pre-check tests passed |
Updates the current docs. Signed-off-by: Deepak Kinni <[email protected]>
[Crossport]velero vSphere plugin docs for v1.3.0 (#420)
Updates the current docs. Signed-off-by: Deepak Kinni <[email protected]>
What this PR does / why we need it:
Updates the current docs.
Which issue(s) this PR fixes:
Fixes: #418
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Signed-off-by: Deepak Kinni [email protected]