Security configuration Azure Storage Account with AKS #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
ashish-amarnath,
carlisia,
dsu-igeek,
nrb and
zubron
aristosvo
force-pushed
the
feature/improved-storage-security-config
branch
from
2aed420 to
b7c6502
Compare
|
thanks for updating this @aristosvo! I noticed that one of the checks failed, can you update this to signoff on your commit, more details here |
Signed-off-by: Aris van Ommeren <[email protected]>
aristosvo
force-pushed
the
feature/improved-storage-security-config
branch
from
b7c6502 to
81cecb5
Compare
nrb
approved these changes
Jan 26, 2021
|
@nrb is this all set to merge or does it need more reviews? thanks |
ashish-amarnath
approved these changes
Feb 19, 2021
yvespp
pushed a commit
to yvespp/velero-plugin-for-microsoft-azure
that referenced
this pull request
May 9, 2022
Signed-off-by: Aris van Ommeren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves vmware-tanzu/velero#3158