Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the documents for the release 1.3.0 #107

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

ywk253100
Copy link
Contributor

Signed-off-by: Wenkai Yin(尹文开) [email protected]

Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
Copy link
Contributor

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be merged after v1.3.0 is released.
I'll review it again once v1.3.0 is released.

@ywk253100
Copy link
Contributor Author

@jenting Thank you for the quick response.
We want to make a RC tag and do some testing based on the RC builds of velero and the plugin. If everything goes well, we will make the GA release from the same commit of the RC directly
So please take a look at this PR

@jenting
Copy link
Contributor

jenting commented Sep 9, 2021

Okay, but I'd prefer separate 2 PRs, one is for RC build and the other one is for updating the README.

@ywk253100
Copy link
Contributor Author

@jenting We just want to make sure all releases follow the same process, the documents are ready for RC release of main velero, so here same to the plugins 🙂

@jenting
Copy link
Contributor

jenting commented Sep 9, 2021

Fine. I just want to make sure the user won't use the wrong version/tag when reading the README of this plugin during the RC testng.
NVM, I'll approve it.

@reasonerjt
Copy link
Contributor

Thanks @jenting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants