-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support requesting CustomPath endpoint for kubeconfig with GetKubeconfigForContext API #152
Support requesting CustomPath endpoint for kubeconfig with GetKubeconfigForContext API #152
Conversation
67f2971
to
4c442e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
suggestion: Please add some UT in tanzu_context_test.go on for ForCustomPath behavior
291fe01
to
3affdb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks
…figForContext API (vmware-tanzu#152) * Support requesting CustomPath endpoint for kubeconfig with GetKubeconfigForContext API * Add KubeConfigBytes field for KubernetesDiscovery
…figForContext API (#152) * Support requesting CustomPath endpoint for kubeconfig with GetKubeconfigForContext API * Add KubeConfigBytes field for KubernetesDiscovery
What this PR does / why we need it
GetKubeconfigForContext
APIKubeConfigBytes
to theKubernetesDiscovery
structWhich issue(s) this PR fixes
Fixes #
Describe testing done for PR
Release note
Additional information
Special notes for your reviewer