Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support requesting CustomPath endpoint for kubeconfig with GetKubeconfigForContext API #152

Merged

Conversation

anujc25
Copy link
Contributor

@anujc25 anujc25 commented Jan 18, 2024

What this PR does / why we need it

  • Support requesting CustomPath endpoint for kubeconfig with GetKubeconfigForContext API
  • Add KubeConfigBytes to the KubernetesDiscovery struct

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Release note

Support requesting CustomPath endpoint for kubeconfig with GetKubeconfigForContext API

Additional information

Special notes for your reviewer

Copy link
Contributor

@vuil vuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.
suggestion: Please add some UT in tanzu_context_test.go on for ForCustomPath behavior

@anujc25 anujc25 force-pushed the support-custom-path-endpoint-kubeconfig branch from 291fe01 to 3affdb0 Compare January 19, 2024 23:36
Copy link
Contributor

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@vuil vuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@anujc25 anujc25 merged commit 021d60b into vmware-tanzu:main Jan 22, 2024
4 checks passed
@anujc25 anujc25 added this to the v1.2.0 milestone Jan 22, 2024
vuil pushed a commit to vuil/tanzu-plugin-runtime that referenced this pull request Jan 22, 2024
…figForContext API (vmware-tanzu#152)

* Support requesting CustomPath endpoint for kubeconfig with GetKubeconfigForContext API

* Add KubeConfigBytes field for KubernetesDiscovery
vuil pushed a commit that referenced this pull request Jan 22, 2024
…figForContext API (#152)

* Support requesting CustomPath endpoint for kubeconfig with GetKubeconfigForContext API

* Add KubeConfigBytes field for KubernetesDiscovery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants