Skip to content

Commit

Permalink
updated knative action workflows names (#521)
Browse files Browse the repository at this point in the history
* updated knative action workflows names

* updated codegen

* updated error message to match expected in test
  • Loading branch information
gabo1208 authored May 4, 2023
1 parent 3af172f commit 8fda92a
Show file tree
Hide file tree
Showing 9 changed files with 18 additions and 20 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/knative-go-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ name: Build

on:
pull_request:
branches: [ 'main', 'release-*' ]
branches: ['main', 'release-*']

jobs:
build:
uses: knative/actions/.github/workflows/go-build.yaml@main
uses: knative/actions/.github/workflows/reusable-go-build.yaml@main
6 changes: 3 additions & 3 deletions .github/workflows/knative-go-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ name: Test

on:
push:
branches: [ 'main', 'release-*' ]
branches: ['main', 'release-*']

pull_request:
branches: [ 'main', 'release-*' ]
branches: ['main', 'release-*']

jobs:
test:
uses: knative/actions/.github/workflows/go-test.yaml@main
uses: knative/actions/.github/workflows/reusable-go-test.yaml@main
4 changes: 2 additions & 2 deletions .github/workflows/knative-releasability.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
schedule:
- cron: '0 1 * * 1-5' # 6am Pacific, weekdays.

workflow_dispatch: # Manual trigger.
workflow_dispatch: # Manual trigger.
inputs:
releaseFamily:
description: 'Release? (vX.Y)'
Expand All @@ -23,7 +23,7 @@ on:

jobs:
releasability:
uses: knative/actions/.github/workflows/releasability.yaml@main
uses: knative/actions/.github/workflows/reusable-releasability.yaml@main
with:
releaseFamily: ${{ github.event.inputs.releaseFamily || 'v1.9' }}
moduleReleaseFamily: ${{ github.event.inputs.moduleReleaseFamily || 'v0.36' }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/knative-release-notes.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ on:

jobs:
release-notes:
uses: knative/actions/.github/workflows/release-notes.yaml@main
uses: knative/actions/.github/workflows/reusable-release-notes.yaml@main
with:
branch: ${{ github.event.inputs.branch }}
start-rev: ${{ github.event.inputs.start-rev }}
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/knative-stale.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,8 @@ name: 'Close stale'

on:
schedule:
- cron: '0 1 * * *'
- cron: '0 1 * * *'

jobs:

stale:
uses: knative/actions/.github/workflows/stale.yaml@main
uses: knative/actions/.github/workflows/reusable-stale.yaml@main
5 changes: 2 additions & 3 deletions .github/workflows/knative-style.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,8 @@ name: Code Style

on:
pull_request:
branches: [ 'main', 'release-*' ]
branches: ['main', 'release-*']

jobs:

style:
uses: knative/actions/.github/workflows/style.yaml@main
uses: knative/actions/.github/workflows/reusable-style.yaml@main
4 changes: 2 additions & 2 deletions .github/workflows/knative-verify.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ name: Verify

on:
pull_request:
branches: [ 'main', 'release-*' ]
branches: ['main', 'release-*']

jobs:
verify:
uses: knative/actions/.github/workflows/verify-codegen.yaml@main
uses: knative/actions/.github/workflows/reusable-verify-codegen.yaml@main
6 changes: 3 additions & 3 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ require (
github.com/elazarl/go-bindata-assetfs v1.0.0 // indirect
github.com/fatih/structs v1.1.0 // indirect
github.com/google/go-cmp v0.5.9
github.com/hashicorp/go-cleanhttp v0.5.2 // indirect
github.com/hashicorp/golang-lru v0.5.4 // indirect
github.com/hashicorp/go-cleanhttp v0.5.2
github.com/hashicorp/golang-lru v0.5.4
github.com/jpillora/backoff v1.0.0
github.com/kelseyhightower/envconfig v1.4.0
github.com/kr/pty v1.1.8 // indirect
Expand All @@ -35,6 +35,7 @@ require (
require (
github.com/benbjohnson/clock v1.1.0
github.com/go-resty/resty/v2 v2.7.0
github.com/hashicorp/hcl v1.0.0
github.com/pkg/errors v0.9.1
github.com/stretchr/testify v1.8.0
golang.org/x/sync v0.1.0
Expand All @@ -47,7 +48,6 @@ require (
github.com/cpuguy83/go-md2man/v2 v2.0.2 // indirect
github.com/emicklei/go-restful/v3 v3.9.0 // indirect
github.com/google/gnostic v0.6.9 // indirect
github.com/hashicorp/hcl v1.0.0 // indirect
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
github.com/opencontainers/go-digest v1.0.0 // indirect
github.com/pelletier/go-toml/v2 v2.0.5 // indirect
Expand Down
2 changes: 1 addition & 1 deletion plugins/vsphere/pkg/command/auth/create_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ func TestNewCreateCommand(t *testing.T) {
})

err := cmd.Execute()
assert.ErrorContains(t, err, fmt.Sprintf(`failed to authenticate with vCenter: Post %q: x509: certificate signed by unknown authority`, vc.URL().String()))
assert.ErrorContains(t, err, fmt.Sprintf(`failed to authenticate with vCenter: Post %q: tls: failed to verify certificate: x509: certificate signed by unknown authority`, vc.URL().String()))
return nil
})
})
Expand Down

0 comments on commit 8fda92a

Please sign in to comment.