Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update badge to be from CircleCI not Travis #953

Merged
merged 1 commit into from
Oct 11, 2019
Merged

Update badge to be from CircleCI not Travis #953

merged 1 commit into from
Oct 11, 2019

Conversation

johnSchnake
Copy link
Contributor

No description provided.

@johnSchnake
Copy link
Contributor Author

FYI I got a weird error on my first push with the check_readme_sync script. Locally it seemed clean; in the logs for circleCI I couldnt tell what the problem was. In the end the resolution was to ensure that each file had the ending newline. Not sure why that would cause the problem, but it seemed to resolve it for me FYI in case we see it again.

@johnSchnake
Copy link
Contributor Author

Went ahead and updated the old docs too since it was very simple/procedural. I didnt want folks to see failing on travis and get the wrong idea.

@johnSchnake johnSchnake requested a review from zubron October 11, 2019 04:37
@codecov-io
Copy link

Codecov Report

Merging #953 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #953   +/-   ##
=======================================
  Coverage   47.78%   47.78%           
=======================================
  Files          76       76           
  Lines        5226     5226           
=======================================
  Hits         2497     2497           
  Misses       2573     2573           
  Partials      156      156

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a673ac1...512632b. Read the comment docs.

@zubron zubron merged commit 71dd2f9 into master Oct 11, 2019
@johnSchnake johnSchnake deleted the circleBadge branch October 11, 2019 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants