Allow multiple result files to be post-processed #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #824 +/- ##
========================================
- Coverage 44.59% 44.5% -0.1%
========================================
Files 76 76
Lines 4619 4624 +5
========================================
- Hits 2060 2058 -2
- Misses 2428 2433 +5
- Partials 131 133 +2
Continue to review full report at Codecov.
|
Instead of allowing users to only process one, or all the result files, allow them to specify an array of file names in their plugin definition to be post-processed. Signed-off-by: Bridget McErlean <[email protected]>
zubron
force-pushed
the
allow-multiple-result-files-821
branch
from
0aab652 to
f0168ba
Compare
|
Hmm, might be a bit much to have tests for each different type to |
johnSchnake
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Instead of allowing users to only process one, or all the result files,
allow them to specify an array of file names in their plugin definition
to be post-processed.
Signed-off-by: Bridget McErlean [email protected]
Which issue(s) this PR fixes
Special notes for your reviewer:
I've added another copy of
sliceContains. I will move this into a shared location following this PR.Release note: