Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create resource directories if not querying for resources #726

Merged
merged 1 commit into from
May 22, 2019
Merged

Don't create resource directories if not querying for resources #726

merged 1 commit into from
May 22, 2019

Conversation

johnSchnake
Copy link
Contributor

What this PR does / why we need it:
Ordering issue in the logic caused the paths to be created even
if the queries were noops. This adds an empty-check before
creating the directories at all.

Which issue(s) this PR fixes
Related to #721

Special notes for your reviewer:

Release note:

Fixed an issue which caused some query directories to be created even if queries were not run on the namespaces corresponding to those directories.

Ordering issue in the logic caused the paths to be created even
if the queries were noops. This adds an empty-check before
creating the directories at all.

Related to #721

Signed-off-by: John Schnake <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #726 into master will increase coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #726      +/-   ##
==========================================
+ Coverage   39.97%   40.01%   +0.03%     
==========================================
  Files          69       69              
  Lines        3892     3894       +2     
==========================================
+ Hits         1556     1558       +2     
  Misses       2235     2235              
  Partials      101      101
Impacted Files Coverage Δ
pkg/discovery/queries.go 14.11% <0%> (-0.17%) ⬇️
cmd/sonobuoy/app/status.go 60.67% <0%> (+2.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9aba66...3c9e788. Read the comment docs.

@johnSchnake johnSchnake merged commit d34e9cf into vmware-tanzu:master May 22, 2019
@johnSchnake johnSchnake deleted the noQueryNoFolder branch May 22, 2019 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants