Goreleaser no longer strips v in version #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes vmware-tanzu#383 Signed-off-by: liz <[email protected]>
liztio
force-pushed
the
fix-goreleaser-version
branch
from
68cc5bc to
41e3a07
Compare
timothysc
reviewed
Mar 16, 2018
| @@ -6,7 +6,7 @@ builds: | |||
| - linux | |||
| goarch: | |||
| - amd64 | |||
| ldflags: -s -w -X github.com/heptio/sonobuoy/pkg/buildinfo.Version={{.Version}} | |||
| ldflags: -s -w -X github.com/heptio/sonobuoy/pkg/buildinfo.Version=v{{.Version}} | |||
There was a problem hiding this comment.
It's weird to me that you need to add back the v it's definitely in the tag.?.?.? Is there some option in Travis?
jhamilton1
pushed a commit
to jhamilton1/sonobuoy
that referenced
this pull request
Jun 27, 2018
Fixes vmware-tanzu#383 Signed-off-by: liz <[email protected]> Signed-off-by: Jesse Hamilton [email protected]
jhamilton1
pushed a commit
to jhamilton1/sonobuoy
that referenced
this pull request
Jun 27, 2018
Fixes vmware-tanzu#383 Signed-off-by: liz <[email protected]> Signed-off-by: Jesse Hamilton [email protected] Signed-off-by: Jesse Hamilton [email protected]
ceridwen
pushed a commit
to ceridwen/sonobuoy
that referenced
this pull request
Jul 19, 2018
Fixes vmware-tanzu#383 Signed-off-by: liz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #383
Signed-off-by: liz [email protected]
What this PR does / why we need it:
Fixes broken release tagging
Which issue(s) this PR fixes
Special notes for your reviewer:
Release note: