Sonobuoy existing preflight check #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuckha
approved these changes
Mar 8, 2018
| return errors.Wrap(err, "error checking for Sonobuoy pod") | ||
| // No error: pod exists | ||
| case err == nil: | ||
| return errors.New("sonobuoy run already exists in this namespace") |
There was a problem hiding this comment.
probably out of scope for this, but what do you think about giving the user some action on a failed preflight? for instance in this case, either delete the pod or run it in a different namespace
There was a problem hiding this comment.
Yeah, I thought about that. It doesn't feel right to put that sort of thing inside of a error message, though. Maybe at some point we could make an ErrorWithSolution() type that had both an Error() and a Solution() method on it, then the CLI could check for the latter?
Signed-off-by: liz <[email protected]>
liztio
force-pushed
the
preflight-sonobuoy'
branch
from
8f79e5d to
aa73717
Compare
jhamilton1
pushed a commit
to jhamilton1/sonobuoy
that referenced
this pull request
Jun 27, 2018
Signed-off-by: liz <[email protected]> Signed-off-by: Jesse Hamilton [email protected]
jhamilton1
pushed a commit
to jhamilton1/sonobuoy
that referenced
this pull request
Jun 27, 2018
Signed-off-by: liz <[email protected]> Signed-off-by: Jesse Hamilton [email protected] Signed-off-by: Jesse Hamilton [email protected]
ceridwen
pushed a commit
to ceridwen/sonobuoy
that referenced
this pull request
Jul 19, 2018
Signed-off-by: liz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks to see if a Sonobuoy pod exists in this namespace already.
Signed-off-by: liz [email protected]