Add vet to tests #126
Merged
Add vet to tests #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liztio
force-pushed
the
liz-fmtvet
branch
2 times, most recently
from
9c12c32 to
21d16d2
Compare
|
Fixes #124 |
timothysc
suggested changes
Nov 2, 2017
| @@ -145,7 +145,7 @@ func TestLoadAllPlugins(t *testing.T) { | |||
| } | |||
|
|
|||
| if len(dsplugin.GetPodSpec().Containers) != 2 { | |||
| t.Fatalf("JobPlugin should have 1 container, got 2", len(jobplugin.GetPodSpec().Containers)) | |||
| t.Fatalf("JobPlugin should have 2 containers, got %d", len(jobplugin.GetPodSpec().Containers)) | |||
There was a problem hiding this comment.
wait now I need to dblcheck
There was a problem hiding this comment.
my bad, ignore this comment.
Makefile
Outdated
| # Vendor this someday | ||
| INSTALL_GOLINT = go get -u github.com/golang/lint/golint | ||
| GOLINT_FLAGS ?= -set_exit_status | ||
| VET = go vet $(TEST_PKGS) && $(INSTALL_GOLINT) && golint $(GOLINT_FLAGS) $(TEST_PKGS) |
There was a problem hiding this comment.
You could probably break this into 2 var..
VET
LINT
There was a problem hiding this comment.
Could also add a gfmt check but now were entering into the whole we should break up the target b/c we're chaining too many things.
Makefile
Outdated
|
|
||
| container: test | ||
| container: test vet |
There was a problem hiding this comment.
why is vet needed here?
test: cbuild vet
Adds `go vet` and `golint` to the `make test` task. Also makes several small, mostly cosmetic changes to bring code into compliance with sed style-checking tools. Signed-off-by: liz <[email protected]>
jhamilton1
pushed a commit
to jhamilton1/sonobuoy
that referenced
this pull request
Jun 27, 2018
Add vet to tests Signed-off-by: Jesse Hamilton [email protected]
jhamilton1
pushed a commit
to jhamilton1/sonobuoy
that referenced
this pull request
Jun 27, 2018
Add vet to tests Signed-off-by: Jesse Hamilton [email protected] Signed-off-by: Jesse Hamilton [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our tests should vet, lint, and otherwise verify the hygiene of our code before we allow it into master