Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare v0.16.5 release #1031

Merged
merged 1 commit into from
Dec 5, 2019
Merged

Conversation

zubron
Copy link
Contributor

@zubron zubron commented Dec 5, 2019

Signed-off-by: Bridget McErlean [email protected]

@zubron zubron requested a review from johnSchnake December 5, 2019 17:39
@codecov-io
Copy link

codecov-io commented Dec 5, 2019

Codecov Report

Merging #1031 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1031      +/-   ##
==========================================
+ Coverage   48.41%   48.45%   +0.03%     
==========================================
  Files          77       77              
  Lines        5498     5498              
==========================================
+ Hits         2662     2664       +2     
+ Misses       2675     2673       -2     
  Partials      161      161
Impacted Files Coverage Δ
cmd/sonobuoy/app/status.go 59.43% <0%> (+1.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a88c74...672ad66. Read the comment docs.

Copy link
Contributor

@johnSchnake johnSchnake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think things are fine once those accidental files get removed.

site/docs/v0.16.5/faq-new.md Outdated Show resolved Hide resolved
Signed-off-by: Bridget McErlean <[email protected]>
@johnSchnake johnSchnake self-requested a review December 5, 2019 18:30
Copy link
Contributor

@johnSchnake johnSchnake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I think we need to add the faq page to the shortlinks so docs/faq works but that is a separate PR than the version bump.

@zubron zubron merged commit 99d45a1 into vmware-tanzu:master Dec 5, 2019
@zubron zubron deleted the release-v0.16.5 branch December 5, 2019 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants