Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken build due to kind #713

Closed
johnSchnake opened this issue May 11, 2019 · 6 comments · Fixed by #714
Closed

Broken build due to kind #713

johnSchnake opened this issue May 11, 2019 · 6 comments · Fixed by #714
Labels
kind/bug Behavior isn't as expected or intended p0-highest
Milestone

Comments

@johnSchnake
Copy link
Contributor

What steps did you take and what happened:
Travis is currently failing due to a problem with getting/installing kind.

49.72s$ go get sigs.k8s.io/kind
# sigs.k8s.io/kind/pkg/kustomize
../../../sigs.k8s.io/kind/pkg/kustomize/kustomize.go:108:7: undefined: k8sdeps.NewFactory
../../../sigs.k8s.io/kind/pkg/kustomize/kustomize.go:109:26: not enough arguments in call to build.NewCmdBuild

What did you expect to happen:
Successful build.

Anything else you would like to add:
I think they recently went to using gomodules and so we may need to tweak something to properly utilize them. (Could be wrong, but locally I hit that because I was in my GOPATH)

@johnSchnake johnSchnake added kind/bug Behavior isn't as expected or intended p0-highest labels May 11, 2019
@johnSchnake johnSchnake added this to the v0.14.3 milestone May 11, 2019
@johnSchnake
Copy link
Contributor Author

kubernetes-sigs/kind#509

@johnSchnake
Copy link
Contributor Author

TL;DR; it seems that we just need to get off from doing go get ... and do a clone/checkout of a specific version. With modules and the lack of vendor now go get is having problems which aren't really problems with kind; master just isn't guaranteed, only tagged releases.

@johnSchnake
Copy link
Contributor Author

GO111MODULE=on go get sigs.k8s.io/kind also works for me locally. Being the fast/easy fix this is sufficient for our our needs in travis IMO.

johnSchnake added a commit that referenced this issue May 11, 2019
Recently moved to modules and removed the vendor directory. In
order to get `go get` to work we need to ensure we are using
the modules as intended.

Fixes #713

Signed-off-by: John Schnake <[email protected]>
@BenTheElder
Copy link

Thanks and sorry about that @johnSchnake, I'd additionally ask to consider using a fixed version so we don't surprise you again :(

0.3 will be out this week, perhaps at that point using a pre-built release binary will be sufficient?

@johnSchnake
Copy link
Contributor Author

Sounds good to me; I had limited availability today so I just did the fastest fix I could find. Happy to fix the version especially if a new release is getting tagged soon.

@BenTheElder
Copy link

Thanks for understanding and apologies again. 0.3 will indeed land before the end of next week I promise, and should let go get without @master pick that instead of HEAD. I'll send a note when it's out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Behavior isn't as expected or intended p0-highest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants