Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump the default timeout #468

Closed
chuckha opened this issue Jul 6, 2018 · 1 comment · Fixed by #478
Closed

Bump the default timeout #468

chuckha opened this issue Jul 6, 2018 · 1 comment · Fixed by #478
Assignees
@chuckha
Labels
kind/bug Behavior isn't as expected or intended lifecycle/active Actively being worked on p1-important

Comments

@chuckha
Copy link
Contributor

chuckha commented Jul 6, 2018

We have seen many instances of the timeout of 5400 being too small. We should double that bump it to twice that, 10800 seconds, or , three hours

This includes updating scanner and all places where we say "up to 60 minutes" since that's false already since we timeout at 1.5 hours.
@chuckha chuckha added the kind/bug Behavior isn't as expected or intended label Jul 6, 2018
@chuckha chuckha added this to the v1.11-upstream sync milestone Jul 6, 2018
@chuckha chuckha self-assigned this Jul 6, 2018
@timothysc timothysc assigned liztio and unassigned chuckha Jul 10, 2018
@timothysc timothysc self-assigned this Jul 10, 2018
@chuckha
Copy link
Contributor Author

chuckha commented Jul 11, 2018

Scanner update is open for review; https://github.com/heptio/outrigger/pull/173. We need to bump the config value and we can close this ticket.

@chuckha chuckha assigned chuckha and unassigned timothysc and liztio Jul 11, 2018
chuckha pushed a commit to chuckha/sonobuoy that referenced this issue Jul 11, 2018
Bump default to 180 minutes (3 hours)
dfa3747 
Along with the scanner update this Fixes vmware-tanzu#468

Signed-off-by: Chuck Ha <[email protected]>
@chuckha chuckha added the lifecycle/active Actively being worked on label Jul 11, 2018
@chuckha chuckha mentioned this issue Jul 11, 2018
Merged
chuckha added a commit that referenced this issue Jul 11, 2018
@chuckha
Bump default to 180 minutes (3 hours) (#478)
6c60763 
Along with the scanner update this Fixes #468

Signed-off-by: Chuck Ha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chuckha chuckha

Labels
kind/bug Behavior isn't as expected or intended lifecycle/active Actively being worked on p1-important
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump default to 180 minutes (3 hours) chuckha/sonobuoy
3 participants
@chuckha @timothysc @liztio