-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make 'sonobuoy retrieve' cli command aware if tarball is available or not #407
Comments
I currently have a very similar problem; I'm thinking the cause is that I'm trying to get the tarball just slightly before its ready (sonobuoy status says it is done with tests) but sometimes I get the tarball and sometimes I get the directory. Frustrating behavior, even if not technically a bug. |
@johnSchnake I was in the same situation - that's why I created this issue. |
sonobuoy retrieve now has better, more user-friendly error handling closes vmware-tanzu#407
sonobuoy retrieve now has better, more user-friendly error handling closes vmware-tanzu#407 Signed-off-by: liz <[email protected]>
sonobuoy retrieve now has better, more user-friendly error handling closes vmware-tanzu#407 Signed-off-by: liz <[email protected]>
sonobuoy retrieve now has better, more user-friendly error handling closes vmware-tanzu#407 Signed-off-by: liz <[email protected]>
sonobuoy retrieve now has better, more user-friendly error handling closes vmware-tanzu#407 Signed-off-by: liz <[email protected]>
sonobuoy retrieve now has better, more user-friendly error handling closes vmware-tanzu#407 Signed-off-by: liz <[email protected]>
sonobuoy retrieve now has better, more user-friendly error handling closes vmware-tanzu#407 Signed-off-by: liz <[email protected]>
* Add errgroup dependency Signed-off-by: liz <[email protected]> * client.Retrieve now returns an error channel instead of error sonobuoy retrieve now has better, more user-friendly error handling closes #407 Signed-off-by: liz <[email protected]>
Is this a BUG REPORT or FEATURE REQUEST?:
FEATURE REQUEST
What happened:
I prepared script to run sonobuoy and gather results. Basically script has steps:
sonobuoy run
sonobuoy retrieve
tar xzf *.tar.gz
Last step failed because there is no tarball after retrieve, just a folder (with UID as name). Sonobuoy returned 0 exit code.
What you expected to happen:
It would be better UX if sonobuoy cli retrieve would return some errorCodes, f.e.:
0 - ok, tarball downloaded
1 - error, cannot retrieve the tarball, not recoverable error
2 (or other number) - tarball not ready, you can try again later
I think it would make scripting easier (now I can just check if there's a tarball in specified folder)
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:
kubectl version
):uname -a
):The text was updated successfully, but these errors were encountered: