v0.54.0 results dir issue

[johnSchnake]

Helping someone with a custom plugin and they were pinned to v0.54.0 which has known results_dir problems. It took a while to debug and I'd just like to make sure we document the known issue so its faster to debug next time.

SONOBUOY_RESULTS_DIR did not match RESULTS_DIR and was causing problems with finding the results.

[johnSchnake]

After looking at the PRs and knowing what the issue is I'm not certain its worth much more effort than throwing this into a known issues listing at most. The fix is just to bump the Sonobuoy version; I think very few people would be stuck on this explicit version and forced to work around it. Considering that release is now approaching a year old, I dont know that it makes too much sense to even put it in the known issues though. Just closing for now.

If they do, they can find this suggestion:

• specify the RESULTS_DIR env var manually on your plugin
• continue to manually specify the results volume mount in your plugin
• make sure the path for the results volume mount matches the resultsDir set in the sonobuoy config (e.g. sonobuoy gen config data, except the one fed into the sonobuoy run/gen you're trying to use)

[johnSchnake]

I've ran into a situation which is close to this. An upgrade is depending on using the older CLI and moving to the new image. Currently this doesn't work.

If we update the resultsDir of the config things would be fine.
If the volumeMounts all matched the results dir, things would be fine.

It may make sense to try and solve this problem on the server-side in a way that doesn't put any onus on users to pass a different config value.